From f6ad0952f4fa656e0a0599ba686437e984fc5211 Mon Sep 17 00:00:00 2001 From: SDK Sync Bot Date: Mon, 16 Feb 2026 13:30:10 +0000 Subject: [PATCH] docs: verify SDK sync for P004 - includeUndefinedDates revert Verified that Python SDK is already synchronized with gdc-nas revert of includeUndefinedDates feature. The feature was added and reverted in gdc-nas before SDK sync, so no code changes are required. - Confirmed OpenAPI client models lack include_empty_values field - Confirmed SDK filter classes never implemented the feature - Confirmed test suite has no references to reverted fields Related: P004, LX-2032, REVERT-19909 Co-Authored-By: Claude Sonnet 4.5 --- .../.sync-notes/P004-verification.md | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 packages/gooddata-sdk/.sync-notes/P004-verification.md diff --git a/packages/gooddata-sdk/.sync-notes/P004-verification.md b/packages/gooddata-sdk/.sync-notes/P004-verification.md new file mode 100644 index 000000000..a1ff600f3 --- /dev/null +++ b/packages/gooddata-sdk/.sync-notes/P004-verification.md @@ -0,0 +1,36 @@ +# P004 Synchronization Verification + +## Problem +Remove includeUndefinedDates flag from DateFilter models and OpenAPI specs + +## gdc-nas Changes +- Commit ef9d814cbb: Merge pull request #20292 (revert) +- Commit 5cfc3badb5: Revert "feat: Introduce includeUndefinedDates flag for DateFilters" +- Reverted feature originally added in commit 675dda483c (LX-2032) + +## SDK Impact Analysis + +### OpenAPI Client Status +✅ **Already synchronized** - OpenAPI client models do not contain the reverted fields: +- `AbsoluteDateFilterAbsoluteDateFilter` - no `include_empty_values` field +- `RelativeDateFilterRelativeDateFilter` - no `include_empty_values` field + +### SDK High-Level API Status +✅ **No changes needed** - SDK filter classes never implemented the reverted feature: +- `AbsoluteDateFilter` class (gooddata_sdk/compute/model/filter.py) +- `RelativeDateFilter` class (gooddata_sdk/compute/model/filter.py) + +### Test Coverage +✅ **Verified** - Test files contain no references to: +- `include_empty_values` +- `include_undefined_dates` +- `includeEmptyValues` +- `includeUndefinedDates` + +## Conclusion +The Python SDK is already in sync with the reverted state from gdc-nas. The feature was added and reverted in gdc-nas (commits 675dda483c → 5cfc3badb5) before any SDK synchronization occurred. No code changes are required. + +## Related Issues +- Jira: LX-2032 (original feature) +- Jira: REVERT-19909 (revert ticket) +- Parent Epic: GDP-3166