From 43774304bb36a44a734cc3f7d85fd6f63cc1f1e8 Mon Sep 17 00:00:00 2001 From: Jan Kadlec Date: Tue, 18 Feb 2025 20:06:35 +0100 Subject: [PATCH] docs: add docstrings DataSourceValidator JIRA: TRIVIAL risk: low --- .../catalog/data_source/validation/data_source.py | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/gooddata-sdk/gooddata_sdk/catalog/data_source/validation/data_source.py b/gooddata-sdk/gooddata_sdk/catalog/data_source/validation/data_source.py index f093490a1..33f968f00 100644 --- a/gooddata-sdk/gooddata_sdk/catalog/data_source/validation/data_source.py +++ b/gooddata-sdk/gooddata_sdk/catalog/data_source/validation/data_source.py @@ -10,6 +10,13 @@ def __init__(self, data_source_service: CatalogDataSourceService): self._ds_service = data_source_service def validate_ldm(self, model: CatalogDeclarativeModel) -> None: + """ + Validates that referenced data sources in LDM actually exist. + If they do not exist, raises ValueError. + + Returns: + None + """ if model.ldm is not None: ldm_ds_in_use = set( dataset.data_source_table_id.data_source_id @@ -19,6 +26,12 @@ def validate_ldm(self, model: CatalogDeclarativeModel) -> None: self.validate_data_source_ids(ldm_ds_in_use) def validate_data_source_ids(self, data_source_ids: set[str]) -> None: + """ + Compares data source ids with existing data sources in the catalog. + + Returns: + None + """ full_ds_set = set(data_source.id for data_source in self._ds_service.list_data_sources()) diff_ds = data_source_ids - full_ds_set if len(diff_ds) != 0: