Rename DEBUG input to GEMINI_DEBUG and pass --debug flag to CLI.
#407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthasaradhie
requested review from
R2wenD2,
benw307,
leehagoodjames and
verbanicm
parthasaradhie
force-pushed
the
main
branch
3 times, most recently
from
54441e5 to
2e8f0ea
Compare
Contributor
Author
|
/gemini review |
Contributor
Author
|
@gemini-cli /review |
1 similar comment
Collaborator
|
@gemini-cli /review |
|
🤖 Hi @MJjainam, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![gemini-cli[bot]](https://avatars.githubusercontent.com/in/1473539?s=60&v=4){kind=small}
There was a problem hiding this comment.
This pull request renames the DEBUG input to GEMINI_DEBUG to avoid conflicts with the Node.js debugger and updates the debug logging mechanism. The changes are generally good, but there are a few important issues to address, including a security policy violation and the use of an unreliable sleep command.
🔍 General Feedback
- The changes to
README.mdare clear and effectively warn users about the previous issues with theDEBUGvariable. - The move to
GEMINI_DEBUGis a good improvement to avoid environment variable collisions.
MJjainam
reviewed
Dec 6, 2025
MJjainam
reviewed
Dec 8, 2025
MJjainam
approved these changes
Dec 8, 2025
Collaborator
|
Should we update all the vars.DEBUG variable to vars.GEMINI_DEBUG ? |
Contributor
Author
Updated all the references |
MJjainam
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #337
Env variable DEBUG is used in CONTRIBUTING.md?plain=1#L356
Setting this to true will start gemini in inspect-brk mode which will wait for node debugger to attach indefinitely. resulting in looks like freeze.
so i have removed the support of the env variable and added warning to users to notify it side effects.