Skip to content

Commit 98d8f78

Browse files
authored
Update linters (#715)
1 parent a8b5801 commit 98d8f78

File tree

4 files changed

+10
-11
lines changed

4 files changed

+10
-11
lines changed

.github/workflows/integration.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ concurrency:
1717

1818
jobs:
1919
integration:
20-
if: ${{ github.event_name == 'workflow_dispatch' || github.event_name == 'push' || github.repository == github.event.pull_request.head.repo.full_name && github.actor != 'dependabot[bot]' }}
20+
if: |-
21+
${{ github.event_name == 'workflow_dispatch' || github.event_name == 'push' || github.repository == github.event.pull_request.head.repo.full_name && github.actor != 'dependabot[bot]' }}
2122
strategy:
2223
fail-fast: false
2324
matrix:
@@ -35,7 +36,7 @@ jobs:
3536

3637
- uses: 'actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a' # ratchet:actions/setup-node@v4
3738
with:
38-
node-version: '20.x'
39+
node-version-file: 'package.json'
3940

4041
- name: 'Build'
4142
run: 'npm ci && npm run build'

.github/workflows/unit.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,19 +31,13 @@ jobs:
3131

3232
- uses: 'actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a' # ratchet:actions/setup-node@v4
3333
with:
34-
node-version: '20.x'
34+
node-version-file: 'package.json'
3535

3636
- name: 'npm ci'
3737
run: 'npm ci'
3838

3939
- name: 'npm build'
4040
run: 'npm run build'
4141

42-
- name: 'run lint'
43-
run: 'npm run lint'
44-
# There's no need to run the linter for each operating system, since it
45-
# will find the same thing 3x and clog up the PR review.
46-
if: ${{ matrix.os == 'ubuntu-latest' }}
47-
4842
- name: 'test'
4943
run: 'npm test'

action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
name: Set up gcloud Cloud SDK environment
16-
author: Google LLC
15+
name: 'Set up gcloud Cloud SDK environment'
16+
author: 'Google LLC'
1717
description: |-
1818
Downloads, installs, and configures a Google Cloud SDK environment.
1919
Adds the `gcloud` CLI command to the $PATH.

package.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@
1111
"lint": "eslint .",
1212
"test": "node --require ts-node/register --test-reporter spec --test tests/setup-gcloud.test.ts"
1313
},
14+
"engines": {
15+
"node": "20.x",
16+
"npm": "10.x"
17+
},
1418
"repository": {
1519
"type": "git",
1620
"url": "https://github.com/google-github-actions/setup-gcloud"

0 commit comments

Comments
 (0)