feat:Bigquery ADK support for search catalog tool

Author: sahaajaaa

src/google/adk/tools/bigquery/search_tool.py

@@ -45,7 +45,7 @@ def search_catalog(
     project_id: str,
     credentials: Credentials,
     settings: BigQueryToolConfig,
-    location: str,
+    location: Optional[str] = None,
     page_size: int = 10,
     project_ids_filter: Optional[List[str]] = None,
     dataset_ids_filter: Optional[List[str]] = None,
@@ -113,7 +113,8 @@ def search_catalog(
 
     full_query = " AND ".join(filter(None, query_parts))
 
-    search_scope = f"projects/{project_id}/locations/{location}"
+    search_location = location or settings.location or "global"
+    search_scope = f"projects/{project_id}/locations/{search_location}"
 
     request = dataplex_v1.SearchEntriesRequest(
         name=search_scope,

tests/unittests/tools/bigquery/test_bigquery_search_tool.py

@@ -69,6 +69,7 @@ def test_search_catalog_success(self):
     settings = _mock_settings()
     prompt = "customer data"
     project_id = "test-project"
+    location = "us"
 
     mock_api_results = [{
         "name": "entry1",
@@ -84,7 +85,9 @@ def test_search_catalog_success(self):
         _mock_search_entries_response(mock_api_results)
     )
 
-    result = search_tool.search_catalog(prompt, project_id, creds, settings)
+    result = search_tool.search_catalog(
+        prompt, project_id, creds, settings, location
+    )
 
     assert result["status"] == "SUCCESS"
     assert len(result["results"]) == 1
@@ -99,7 +102,7 @@ def test_search_catalog_success(self):
         '(customer data) AND projectid="test-project" AND system=BIGQUERY'
     )
     self.mock_search_request.assert_called_once_with(
-        name=f"projects/{project_id}/locations/global",
+        name=f"projects/{project_id}/locations/us",
         query=expected_query,
         page_size=10,
         semantic_search=True,
@@ -111,7 +114,7 @@ def test_search_catalog_success(self):
   def test_search_catalog_no_project_id(self):
     """Test search_catalog with missing project_id."""
     result = search_tool.search_catalog(
-        "test", "", _mock_creds(), _mock_settings()
+        "test", "", _mock_creds(), _mock_settings(), "us"
     )
     assert result["status"] == "ERROR"
     assert "project_id must be provided" in result["error_details"]
@@ -124,10 +127,10 @@ def test_search_catalog_api_error(self):
     )
 
     result = search_tool.search_catalog(
-        "test", "test-project", _mock_creds(), _mock_settings()
+        "test", "test-project", _mock_creds(), _mock_settings(), "us"
     )
     assert result["status"] == "ERROR"
-    assert "Dataplex API Error: Invalid query" in result["error_details"]
+    assert "Dataplex API Error: 400 Invalid query" in result["error_details"]
 
   def test_search_catalog_other_exception(self):
     """Test search_catalog handling unexpected exceptions."""
@@ -136,7 +139,7 @@ def test_search_catalog_other_exception(self):
     )
 
     result = search_tool.search_catalog(
-        "test", "test-project", _mock_creds(), _mock_settings()
+        "test", "test-project", _mock_creds(), _mock_settings(), "us"
     )
     assert result["status"] == "ERROR"
     assert "Something went wrong" in result["error_details"]
@@ -166,6 +169,7 @@ def test_search_catalog_query_construction(
         "test-project",
         _mock_creds(),
         _mock_settings(),
+        "us",
         project_ids_filter=project_ids,
         dataset_ids_filter=dataset_ids,
         types_filter=types,
@@ -184,7 +188,7 @@ def test_search_catalog_no_app_name(self):
     """Test search_catalog when settings.application_name is None."""
     creds = _mock_creds()
     settings = _mock_settings(app_name=None)
-    search_tool.search_catalog("test", "test-project", creds, settings)
+    search_tool.search_catalog("test", "test-project", creds, settings, "us")
 
     self.mock_get_dataplex_client.assert_called_once_with(
         credentials=creds, user_agent=[None, "search_catalog"]
@@ -330,3 +334,38 @@ def test_query_with_project_and_dataset_filters(self):
     self.mock_dataplex_client.search_entries.assert_called_once_with(
         request=self.mock_search_request.return_value
     )
+
+  def test_search_catalog_default_location(self):
+    """Test search_catalog fallback to global location when None is provided."""
+    creds = _mock_creds()
+    settings = _mock_settings()
+    # settings.location is None by default
+
+    self.mock_dataplex_client.search_entries.return_value = (
+        _mock_search_entries_response([])
+    )
+
+    search_tool.search_catalog(
+        "test", "test-project", creds, settings  # location omitted
+    )
+
+    self.mock_search_request.assert_called_once()
+    name_arg = self.mock_search_request.call_args[1]["name"]
+    assert "locations/global" in name_arg
+
+  def test_search_catalog_settings_location(self):
+    """Test search_catalog uses settings.location when provided."""
+    creds = _mock_creds()
+    settings = BigQueryToolConfig(location="eu")
+
+    self.mock_dataplex_client.search_entries.return_value = (
+        _mock_search_entries_response([])
+    )
+
+    search_tool.search_catalog(
+        "test", "test-project", creds, settings  # location omitted
+    )
+
+    self.mock_search_request.assert_called_once()
+    name_arg = self.mock_search_request.call_args[1]["name"]
+    assert "locations/eu" in name_arg