Skip to content

Commit ca62e21

Browse files
committed
moved None comparison higher for Fail-fast principle purposes
1 parent 43fffc3 commit ca62e21

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

src/google/adk/evaluation/local_eval_service.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -271,15 +271,6 @@ async def _evaluate_single_inference_result(
271271
else 'test_user_id'
272272
)
273273

274-
if inference_result.status == InferenceStatus.FAILURE:
275-
eval_case_result = await self._build_not_evaluated_eval_case_result(
276-
inference_result=inference_result,
277-
eval_case=eval_case,
278-
user_id=user_id,
279-
reason='Inference status indicates failure',
280-
)
281-
return (inference_result, eval_case_result)
282-
283274
if inference_result.inferences is None:
284275
logger.error(
285276
'Evaluation attempted on failed inference for eval case `%s`.'
@@ -295,6 +286,15 @@ async def _evaluate_single_inference_result(
295286
)
296287
return (inference_result, eval_case_result)
297288

289+
if inference_result.status == InferenceStatus.FAILURE:
290+
eval_case_result = await self._build_not_evaluated_eval_case_result(
291+
inference_result=inference_result,
292+
eval_case=eval_case,
293+
user_id=user_id,
294+
reason='Inference status indicates failure',
295+
)
296+
return (inference_result, eval_case_result)
297+
298298
if eval_case.conversation_scenario is None and len(
299299
inference_result.inferences
300300
) != len(eval_case.conversation):

0 commit comments

Comments
 (0)