Add iteration limit control to planned comprehensions

PiperOrigin-RevId: 850043882

Author: l46kok

common/exceptions/BUILD.bazel

@@ -40,3 +40,9 @@ java_library(
     # used_by_android
     exports = ["//common/src/main/java/dev/cel/common/exceptions:invalid_argument"],
 )
+
+java_library(
+    name = "iteration_budget_exceeded",
+    # used_by_android
+    exports = ["//common/src/main/java/dev/cel/common/exceptions:iteration_budget_exceeded"],
+)

common/src/main/java/dev/cel/common/exceptions/BUILD.bazel

@@ -85,3 +85,16 @@ java_library(
         "//common/annotations",
     ],
 )
+
+java_library(
+    name = "iteration_budget_exceeded",
+    srcs = ["CelIterationLimitExceededException.java"],
+    # used_by_android
+    tags = [
+    ],
+    deps = [
+        "//common:error_codes",
+        "//common:runtime_exception",
+        "//common/annotations",
+    ],
+)

common/src/main/java/dev/cel/common/exceptions/CelIterationLimitExceededException.java

@@ -0,0 +1,31 @@
+// Copyright 2025 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package dev.cel.common.exceptions;
+
+import dev.cel.common.CelErrorCode;
+import dev.cel.common.CelRuntimeException;
+import dev.cel.common.annotations.Internal;
+import java.util.Locale;
+
+/** Indicates that the iteration budget for a comprehension has been exceeded. */
+@Internal
+public final class CelIterationLimitExceededException extends CelRuntimeException {
+
+  public CelIterationLimitExceededException(int budget) {
+    super(
+        String.format(Locale.US, "Iteration budget exceeded: %d", budget),
+        CelErrorCode.ITERATION_BUDGET_EXCEEDED);
+  }
+}

runtime/src/main/java/dev/cel/runtime/AccumulatedUnknowns.java

@@ -2,7 +2,7 @@
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
-// You may obtain a copy of the License aj
+// You may obtain a copy of the License at
 //
 //      https://www.apache.org/licenses/LICENSE-2.0
 //

runtime/src/main/java/dev/cel/runtime/planner/Attribute.java

@@ -20,7 +20,7 @@
 /** Represents a resolvable symbol or path (such as a variable or a field selection). */
 @Immutable
 interface Attribute {
-  Object resolve(GlobalResolver ctx);
+  Object resolve(GlobalResolver ctx, ExecutionFrame frame);
 
   Attribute addQualifier(Qualifier qualifier);
 }

runtime/src/main/java/dev/cel/runtime/planner/BUILD.bazel

@@ -37,6 +37,7 @@ java_library(
         "//common:cel_ast",
         "//common:container",
         "//common:operator",
+        "//common:options",
         "//common/annotations",
         "//common/ast",
         "//common/types",
@@ -59,11 +60,14 @@ java_library(
     srcs = ["PlannedProgram.java"],
     deps = [
         ":error_metadata",
+        ":execution_frame",
         ":planned_interpretable",
         ":strict_error_exception",
         "//:auto_value",
+        "//common:options",
         "//common:runtime_exception",
         "//common/values",
+        "//runtime",
         "//runtime:activation",
         "//runtime:evaluation_exception",
         "//runtime:evaluation_exception_builder",
@@ -78,11 +82,10 @@ java_library(
     name = "eval_const",
     srcs = ["EvalConstant.java"],
     deps = [
+        ":execution_frame",
         ":planned_interpretable",
         "//common/values",
         "//common/values:cel_byte_string",
-        "//runtime:evaluation_listener",
-        "//runtime:function_resolver",
         "//runtime:interpretable",
         "@maven//:com_google_errorprone_error_prone_annotations",
         "@maven//:com_google_guava_guava",
@@ -111,6 +114,7 @@ java_library(
     ],
     deps = [
         ":eval_helpers",
+        ":execution_frame",
         ":planned_interpretable",
         ":qualifier",
         "//common:container",
@@ -158,10 +162,9 @@ java_library(
     srcs = ["EvalAttribute.java"],
     deps = [
         ":attribute",
+        ":execution_frame",
         ":interpretable_attribute",
         ":qualifier",
-        "//runtime:evaluation_listener",
-        "//runtime:function_resolver",
         "//runtime:interpretable",
         "@maven//:com_google_errorprone_error_prone_annotations",
         "@maven//:com_google_guava_guava",
@@ -172,12 +175,11 @@ java_library(
     name = "eval_test_only",
     srcs = ["EvalTestOnly.java"],
     deps = [
+        ":execution_frame",
         ":interpretable_attribute",
         ":presence_test_qualifier",
         ":qualifier",
         "//runtime:evaluation_exception",
-        "//runtime:evaluation_listener",
-        "//runtime:function_resolver",
         "//runtime:interpretable",
         "@maven//:com_google_errorprone_error_prone_annotations",
     ],
@@ -187,10 +189,9 @@ java_library(
     name = "eval_zero_arity",
     srcs = ["EvalZeroArity.java"],
     deps = [
+        ":execution_frame",
         ":planned_interpretable",
         "//runtime:evaluation_exception",
-        "//runtime:evaluation_listener",
-        "//runtime:function_resolver",
         "//runtime:interpretable",
         "//runtime:resolved_overload",
     ],
@@ -201,10 +202,9 @@ java_library(
     srcs = ["EvalUnary.java"],
     deps = [
         ":eval_helpers",
+        ":execution_frame",
         ":planned_interpretable",
         "//runtime:evaluation_exception",
-        "//runtime:evaluation_listener",
-        "//runtime:function_resolver",
         "//runtime:interpretable",
         "//runtime:resolved_overload",
     ],
@@ -215,10 +215,9 @@ java_library(
     srcs = ["EvalVarArgsCall.java"],
     deps = [
         ":eval_helpers",
+        ":execution_frame",
         ":planned_interpretable",
         "//runtime:evaluation_exception",
-        "//runtime:evaluation_listener",
-        "//runtime:function_resolver",
         "//runtime:interpretable",
         "//runtime:resolved_overload",
     ],
@@ -229,10 +228,9 @@ java_library(
     srcs = ["EvalOr.java"],
     deps = [
         ":eval_helpers",
+        ":execution_frame",
         ":planned_interpretable",
         "//common/values",
-        "//runtime:evaluation_listener",
-        "//runtime:function_resolver",
         "//runtime:interpretable",
         "@maven//:com_google_guava_guava",
     ],
@@ -243,10 +241,9 @@ java_library(
     srcs = ["EvalAnd.java"],
     deps = [
         ":eval_helpers",
+        ":execution_frame",
         ":planned_interpretable",
         "//common/values",
-        "//runtime:evaluation_listener",
-        "//runtime:function_resolver",
         "//runtime:interpretable",
         "@maven//:com_google_guava_guava",
     ],
@@ -256,10 +253,9 @@ java_library(
     name = "eval_conditional",
     srcs = ["EvalConditional.java"],
     deps = [
+        ":execution_frame",
         ":planned_interpretable",
         "//runtime:evaluation_exception",
-        "//runtime:evaluation_listener",
-        "//runtime:function_resolver",
         "//runtime:interpretable",
         "@maven//:com_google_guava_guava",
     ],
@@ -269,13 +265,12 @@ java_library(
     name = "eval_create_struct",
     srcs = ["EvalCreateStruct.java"],
     deps = [
+        ":execution_frame",
         ":planned_interpretable",
         "//common/types",
         "//common/values",
         "//common/values:cel_value_provider",
         "//runtime:evaluation_exception",
-        "//runtime:evaluation_listener",
-        "//runtime:function_resolver",
         "//runtime:interpretable",
         "@maven//:com_google_errorprone_error_prone_annotations",
         "@maven//:com_google_guava_guava",
@@ -286,10 +281,9 @@ java_library(
     name = "eval_create_list",
     srcs = ["EvalCreateList.java"],
     deps = [
+        ":execution_frame",
         ":planned_interpretable",
         "//runtime:evaluation_exception",
-        "//runtime:evaluation_listener",
-        "//runtime:function_resolver",
         "//runtime:interpretable",
         "@maven//:com_google_errorprone_error_prone_annotations",
         "@maven//:com_google_guava_guava",
@@ -300,10 +294,9 @@ java_library(
     name = "eval_create_map",
     srcs = ["EvalCreateMap.java"],
     deps = [
+        ":execution_frame",
         ":planned_interpretable",
         "//runtime:evaluation_exception",
-        "//runtime:evaluation_listener",
-        "//runtime:function_resolver",
         "//runtime:interpretable",
         "@maven//:com_google_errorprone_error_prone_annotations",
         "@maven//:com_google_guava_guava",
@@ -314,22 +307,33 @@ java_library(
     name = "eval_fold",
     srcs = ["EvalFold.java"],
     deps = [
+        ":execution_frame",
         ":planned_interpretable",
         "//runtime:concatenated_list_view",
         "//runtime:evaluation_exception",
-        "//runtime:evaluation_listener",
-        "//runtime:function_resolver",
         "//runtime:interpretable",
         "@maven//:com_google_errorprone_error_prone_annotations",
         "@maven//:com_google_guava_guava",
         "@maven//:org_jspecify_jspecify",
     ],
 )
 
+java_library(
+    name = "execution_frame",
+    srcs = ["ExecutionFrame.java"],
+    deps = [
+        "//common:options",
+        "//common/exceptions:iteration_budget_exceeded",
+        "//runtime:interpretable",
+        "@maven//:org_jspecify_jspecify",
+    ],
+)
+
 java_library(
     name = "eval_helpers",
     srcs = ["EvalHelpers.java"],
     deps = [
+        ":execution_frame",
         ":planned_interpretable",
         ":strict_error_exception",
         "//common:error_codes",
@@ -362,6 +366,8 @@ java_library(
     name = "planned_interpretable",
     srcs = ["PlannedInterpretable.java"],
     deps = [
+        ":execution_frame",
+        "//runtime:evaluation_exception",
         "//runtime:interpretable",
         "@maven//:com_google_errorprone_error_prone_annotations",
     ],

runtime/src/main/java/dev/cel/runtime/planner/EvalAnd.java

@@ -18,8 +18,6 @@
 
 import com.google.common.base.Preconditions;
 import dev.cel.common.values.ErrorValue;
-import dev.cel.runtime.CelEvaluationListener;
-import dev.cel.runtime.CelFunctionResolver;
 import dev.cel.runtime.GlobalResolver;
 
 final class EvalAnd extends PlannedInterpretable {
@@ -28,10 +26,10 @@ final class EvalAnd extends PlannedInterpretable {
   private final PlannedInterpretable[] args;
 
   @Override
-  public Object eval(GlobalResolver resolver) {
+  public Object eval(GlobalResolver resolver, ExecutionFrame frame) {
     ErrorValue errorValue = null;
     for (PlannedInterpretable arg : args) {
-      Object argVal = evalNonstrictly(arg, resolver);
+      Object argVal = evalNonstrictly(arg, resolver, frame);
       if (argVal instanceof Boolean) {
         // Short-circuit on false
         if (!((boolean) argVal)) {
@@ -53,27 +51,6 @@ public Object eval(GlobalResolver resolver) {
     return true;
   }
 
-  @Override
-  public Object eval(GlobalResolver resolver, CelEvaluationListener listener) {
-    // TODO: Implement support
-    throw new UnsupportedOperationException("Not yet supported");
-  }
-
-  @Override
-  public Object eval(GlobalResolver resolver, CelFunctionResolver lateBoundFunctionResolver) {
-    // TODO: Implement support
-    throw new UnsupportedOperationException("Not yet supported");
-  }
-
-  @Override
-  public Object eval(
-      GlobalResolver resolver,
-      CelFunctionResolver lateBoundFunctionResolver,
-      CelEvaluationListener listener) {
-    // TODO: Implement support
-    throw new UnsupportedOperationException("Not yet supported");
-  }
-
   static EvalAnd create(long exprId, PlannedInterpretable[] args) {
     return new EvalAnd(exprId, args);
   }