From 8b5f58a1916d7e471d862c86d7e427a7152cb808 Mon Sep 17 00:00:00 2001 From: barnesjoseph Date: Thu, 20 Mar 2025 11:10:44 -0700 Subject: [PATCH 1/2] Update deploy.yaml --- cloudbuild/deploy.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/cloudbuild/deploy.yaml b/cloudbuild/deploy.yaml index e051abfb..587a8c17 100644 --- a/cloudbuild/deploy.yaml +++ b/cloudbuild/deploy.yaml @@ -14,22 +14,22 @@ timeout: 1800s steps: -- name: 'node:16' +- name: 'node:18' entrypoint: 'npm' args: ['--prefix=shared', 'install'] -- name: 'node:16' +- name: 'node:18' entrypoint: 'npm' args: ['--prefix=app', 'install'] -- name: 'node:16' +- name: 'node:18' entrypoint: 'npm' args: ['--prefix=functions', 'install'] -- name: 'node:16' +- name: 'node:18' entrypoint: 'npm' args: ['--prefix=functions', 'run', 'build'] -- name: 'node:16' +- name: 'node:18' entrypoint: 'npm' args: ['--prefix=app', 'run', 'build:$PROJECT_ID'] -- name: 'node:16' +- name: 'node:18' entrypoint: 'npm' args: ['--prefix=shared', 'run', 'deploy:firebase'] env: From a7f442e2db14a9ec60d28392840520b7e5cba8c8 Mon Sep 17 00:00:00 2001 From: barnesjoseph Date: Thu, 20 Mar 2025 11:18:23 -0700 Subject: [PATCH 2/2] Updates node versions --- .github/workflows/build.yml | 2 +- .github/workflows/test.yml | 2 +- app/app.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 307ef82b..261e7a63 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -31,7 +31,7 @@ jobs: strategy: matrix: node-version: - - 16.x + - 18.x steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 17748f02..03ddc999 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -27,7 +27,7 @@ jobs: strategy: matrix: node-version: - - 16.x + - 18.x steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 diff --git a/app/app.yaml b/app/app.yaml index 7f23e1be..51c3b3f6 100644 --- a/app/app.yaml +++ b/app/app.yaml @@ -12,7 +12,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -runtime: nodejs16 +runtime: nodejs18 handlers: # Serve all static files with url ending with a file extension - url: /(.*\..+)$