Skip to content

Commit 5d7f82b

Browse files
authored
Remove lint warnings (#344)
1 parent eca9d4d commit 5d7f82b

File tree

8 files changed

+518
-503
lines changed

8 files changed

+518
-503
lines changed

flexbox/src/androidTest/java/com/google/android/flexbox/test/FlexboxAndroidTest.java

Lines changed: 413 additions & 414 deletions
Large diffs are not rendered by default.

flexbox/src/androidTest/java/com/google/android/flexbox/test/FlexboxLayoutManagerConfigChangeTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public void testFlexLinesDiscardedOnOrientationChange_direction_row() throws Thr
7474
@Override
7575
public void run() {
7676
activity.setContentView(R.layout.recyclerview);
77-
RecyclerView recyclerView = (RecyclerView) activity.findViewById(R.id.recyclerview);
77+
RecyclerView recyclerView = activity.findViewById(R.id.recyclerview);
7878
// This test assumes that the screen width and the height are different.
7979
recyclerView.getLayoutParams().height = ViewGroup.LayoutParams.MATCH_PARENT;
8080
recyclerView.getLayoutParams().width = ViewGroup.LayoutParams.MATCH_PARENT;
@@ -134,7 +134,7 @@ public void testFlexLinesDiscardedOnOrientationChange_direction_column() throws
134134
@Override
135135
public void run() {
136136
activity.setContentView(R.layout.recyclerview);
137-
RecyclerView recyclerView = (RecyclerView) activity.findViewById(R.id.recyclerview);
137+
RecyclerView recyclerView = activity.findViewById(R.id.recyclerview);
138138
// This test assumes that the screen width and the height are different.
139139
recyclerView.getLayoutParams().height = ViewGroup.LayoutParams.MATCH_PARENT;
140140
recyclerView.getLayoutParams().width = ViewGroup.LayoutParams.MATCH_PARENT;

flexbox/src/androidTest/java/com/google/android/flexbox/test/FlexboxLayoutManagerTest.java

Lines changed: 80 additions & 79 deletions
Large diffs are not rendered by default.

flexbox/src/androidTest/java/com/google/android/flexbox/test/NestedInnerAdapter.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ public NestedInnerAdapter.InnerViewHolder onCreateViewHolder(ViewGroup parent, i
4646

4747
@Override
4848
public void onBindViewHolder(InnerViewHolder holder, int position) {
49-
holder.mTextView.setText(mInnerPosition + "-" + position);
49+
String description = holder.mTextView.getResources().getString(R.string.item_description);
50+
holder.mTextView.setText(String.format(description, mInnerPosition, position));
5051
}
5152

5253
@Override
@@ -61,7 +62,7 @@ static class InnerViewHolder extends RecyclerView.ViewHolder {
6162
InnerViewHolder(View itemView) {
6263
super(itemView);
6364

64-
mTextView = (TextView) itemView.findViewById(R.id.textview);
65+
mTextView = itemView.findViewById(R.id.textview);
6566
}
6667
}
6768
}

flexbox/src/androidTest/java/com/google/android/flexbox/test/NestedOuterAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ static class OuterViewHolder extends RecyclerView.ViewHolder {
8989
OuterViewHolder(View itemView) {
9090
super(itemView);
9191

92-
mInnerRecyclerView = (RecyclerView) itemView.findViewById(R.id.recyclerview_inner);
92+
mInnerRecyclerView = itemView.findViewById(R.id.recyclerview_inner);
9393
}
9494
}
9595
}

flexbox/src/androidTest/java/com/google/android/flexbox/test/TestAdapterMultiViewTypes.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,6 @@ void addItemAt(int position, Item item) {
8383
notifyItemInserted(position);
8484
}
8585

86-
Item getItemAt(int position) {
87-
return mItems.get(position);
88-
}
89-
9086
@Override
9187
public int getItemCount() {
9288
return mItems.size();

flexbox/src/androidTest/java/com/google/android/flexbox/test/TestViewHolder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,6 @@ class TestViewHolder extends RecyclerView.ViewHolder {
3030
TestViewHolder(View itemView) {
3131
super(itemView);
3232

33-
mTextView = (TextView) itemView.findViewById(R.id.textview);
33+
mTextView = itemView.findViewById(R.id.textview);
3434
}
3535
}
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
<?xml version="1.0" encoding="utf-8"?><!--
2+
Copyright 2017 Google Inc. All rights reserved.
3+
4+
Licensed under the Apache License, Version 2.0 (the "License");
5+
you may not use this file except in compliance with the License.
6+
You may obtain a copy of the License at
7+
8+
http://www.apache.org/licenses/LICENSE-2.0
9+
10+
Unless required by applicable law or agreed to in writing, software
11+
distributed under the License is distributed on an "AS IS" BASIS,
12+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
See the License for the specific language governing permissions and
14+
limitations under the License.
15+
-->
16+
<resources>
17+
<string name="item_description">%1$s - %2$s</string>
18+
</resources>

0 commit comments

Comments
 (0)