Skip to content

Commit 649a8d7

Browse files
committed
Fix the invalid scroll with the following configuration (#321)
- flexDirection is column or column_reverse - layout direction is RTL (e.g. language is set to RTL language) If these conditions are met, the scroll direction is considered as opposite since the start and end direction should be considered as oppsite from the normal case.
1 parent 880d771 commit 649a8d7

File tree

3 files changed

+189
-56
lines changed

3 files changed

+189
-56
lines changed

flexbox/src/androidTest/java/com/google/android/flexbox/test/FlexboxLayoutManagerTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3250,6 +3250,8 @@ public void run() {
32503250
GeneralLocation.BOTTOM_CENTER));
32513251
onView(withId(R.id.recyclerview)).perform(swipe(GeneralLocation.TOP_CENTER,
32523252
GeneralLocation.BOTTOM_CENTER));
3253+
onView(withId(R.id.recyclerview)).perform(swipe(GeneralLocation.TOP_CENTER,
3254+
GeneralLocation.BOTTOM_CENTER));
32533255
InstrumentationRegistry.getInstrumentation().waitForIdleSync();
32543256

32553257
// Since a new item is inserted before the position, the index at the view who has the

flexbox/src/main/java/com/google/android/flexbox/FlexLine.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,16 +31,12 @@ public class FlexLine {
3131
FlexLine() {
3232
}
3333

34-
/** @see #getLeft() */
3534
int mLeft = Integer.MAX_VALUE;
3635

37-
/** @see #getTop() */
3836
int mTop = Integer.MAX_VALUE;
3937

40-
/** @see #getRight() */
4138
int mRight = Integer.MIN_VALUE;
4239

43-
/** @see #getBottom() */
4440
int mBottom = Integer.MIN_VALUE;
4541

4642
/** @see #getMainSize() */

0 commit comments

Comments
 (0)