Skip to content

Commit 9732648

Browse files
authored
Some improvements for Kotlin (#333)
Address review comments from magiepooh #329 after the original PR is merged.
1 parent dc53ff3 commit 9732648

File tree

2 files changed

+9
-13
lines changed

2 files changed

+9
-13
lines changed

demo-playground/src/main/java/com/google/android/flexbox/FlexItemClickListener.kt

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,10 @@ import android.view.View
2626
internal class FlexItemClickListener(private val activity: AppCompatActivity, private val flexItemChangedListener: FlexItemChangedListener,
2727
private val viewIndex: Int) : View.OnClickListener {
2828

29-
override fun onClick(v: View) {
30-
val fragment = FlexItemEditFragment
31-
.newInstance(v.layoutParams as FlexItem, viewIndex)
32-
fragment.setFlexItemChangedListener(flexItemChangedListener)
33-
fragment.show(activity.supportFragmentManager, EDIT_DIALOG_TAG)
34-
}
29+
override fun onClick(v: View) =
30+
FlexItemEditFragment.newInstance(v.layoutParams as FlexItem, viewIndex).apply {
31+
setFlexItemChangedListener(flexItemChangedListener)
32+
}.show(activity.supportFragmentManager, EDIT_DIALOG_TAG)
3533

3634
companion object {
3735

demo-playground/src/main/java/com/google/android/flexbox/FlexItemEditFragment.kt

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -374,13 +374,11 @@ internal class FlexItemEditFragment : DialogFragment() {
374374

375375
private const val VIEW_INDEX_KEY = "view_index"
376376

377-
fun newInstance(flexItem: FlexItem, viewIndex: Int): FlexItemEditFragment {
378-
val fragment = FlexItemEditFragment()
379-
val args = Bundle()
380-
args.putParcelable(FLEX_ITEM_KEY, flexItem)
381-
args.putInt(VIEW_INDEX_KEY, viewIndex)
382-
fragment.arguments = args
383-
return fragment
377+
fun newInstance(flexItem: FlexItem, viewIndex: Int) = FlexItemEditFragment().apply {
378+
arguments = Bundle().apply {
379+
putParcelable(FLEX_ITEM_KEY, flexItem)
380+
putInt(VIEW_INDEX_KEY, viewIndex)
381+
}
384382
}
385383
}
386384
}

0 commit comments

Comments
 (0)