Skip to content

Commit 13c630a

Browse files
committed
chore: remove code formatting for samples dir
1 parent bfe3b14 commit 13c630a

File tree

303 files changed

+1240
-942
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

303 files changed

+1240
-942
lines changed

gapic/samplegen/samplegen.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ def _normal_request_setup(self, base_param_to_attrs, val, request, field):
416416
)
417417
del request["field"]
418418

419-
if isinstance(request["value"], str):
419+
if isinstance(request["value"], str) or isinstance(request["value"], list):
420420
# Passing value through json is a safe and simple way of
421421
# making sure strings are properly wrapped and quotes escaped.
422422
# This statement both wraps enums in quotes and escapes quotes
@@ -426,6 +426,9 @@ def _normal_request_setup(self, base_param_to_attrs, val, request, field):
426426
# This is preferable to adding the necessary import statement
427427
# and requires less munging of the assigned value
428428
request["value"] = json.dumps(request["value"])
429+
elif isinstance(request["value"], bytes):
430+
# Use double quotes for bytes literals for consistency.
431+
request["value"] = f'b"{request["value"].decode("utf-8")}"'
429432

430433
# Mypy isn't smart enough to handle dictionary unpacking,
431434
# so disable it for the AttributeRequestSetup ctor call.

gapic/templates/examples/feature_fragments.j2

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,11 +174,15 @@ client = {{ module_name }}.{{ client_name }}()
174174
{% endif %}
175175
{% endfor %}
176176
{% if not full_request.flattenable %}
177+
{% if full_request.request_list|length > 0 %}
177178
request = {{ module_name }}.{{ request_type.ident.name }}(
178179
{% for parameter in full_request.request_list %}
179180
{{ parameter.base }}={{ parameter.base if parameter.body else parameter.single.value }},
180181
{% endfor %}
181182
)
183+
{% else %}
184+
request = {{ module_name }}.{{ request_type.ident.name }}()
185+
{% endif %}
182186
{# Note: This template assumes only one request needs to be sent. When samples accept
183187
configs the client streaming logic should be modified to allow 2+ request objects. #}
184188
{# If client streaming, wrap the single request in a generator that produces 'requests' #}
@@ -256,8 +260,8 @@ operation
256260
# Make the request
257261
{% if calling_form in [calling_form_enum.Request, calling_form_enum.RequestStreamingClient] %}
258262
{% if response_statements %}response = {% endif %}{{ method_invocation_text|trim }}
259-
260263
{% if response_statements %}
264+
261265
# Handle the response
262266
{% for statement in response_statements %}
263267
{{ dispatch_statement(statement)|trim }}

gapic/templates/examples/sample.py.j2

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
{{ frags.render_calling_form(method_call, calling_form, calling_form_enum, sample.transport, sample.response)|indent -}}
4040
{% endwith %}
4141

42+
4243
# [END {{ sample.id }}]
4344
{# TODO: Enable main block (or decide to remove main block from python sample) #}
4445
{# {{ frags.render_main_block(sample, sample.request) }} #}

gapic/templates/noxfile.py.j2

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,9 @@ LINT_PATHS = ["docs", "{{ api.naming.versioned_module_name }}", "tests", "noxfil
2727
# and less concerned about the line length.
2828
LINT_LINE_LENGTH = 150
2929

30-
# Add samples to the list of directories to format if the directory exists.
30+
# Add samples to the list of directories to lint if the directory exists.
3131
if os.path.isdir("samples"):
3232
LINT_PATHS.append("samples")
33-
FORMAT_PATHS.append("samples")
3433

3534
ALL_PYTHON = [
3635
"3.7",

tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/async_client.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2439,8 +2439,7 @@ async def sample_update_saved_query():
24392439
client = asset_v1.AssetServiceAsyncClient()
24402440
24412441
# Initialize request argument(s)
2442-
request = asset_v1.UpdateSavedQueryRequest(
2443-
)
2442+
request = asset_v1.UpdateSavedQueryRequest()
24442443
24452444
# Make the request
24462445
response = await client.update_saved_query(request=request)
@@ -2660,7 +2659,7 @@ async def sample_batch_get_effective_iam_policies():
26602659
# Initialize request argument(s)
26612660
request = asset_v1.BatchGetEffectiveIamPoliciesRequest(
26622661
scope="scope_value",
2663-
names=['names_value1', 'names_value2'],
2662+
names=["names_value1", "names_value2"],
26642663
)
26652664
26662665
# Make the request

tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/client.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2939,8 +2939,7 @@ def sample_update_saved_query():
29392939
client = asset_v1.AssetServiceClient()
29402940
29412941
# Initialize request argument(s)
2942-
request = asset_v1.UpdateSavedQueryRequest(
2943-
)
2942+
request = asset_v1.UpdateSavedQueryRequest()
29442943
29452944
# Make the request
29462945
response = client.update_saved_query(request=request)
@@ -3158,7 +3157,7 @@ def sample_batch_get_effective_iam_policies():
31583157
# Initialize request argument(s)
31593158
request = asset_v1.BatchGetEffectiveIamPoliciesRequest(
31603159
scope="scope_value",
3161-
names=['names_value1', 'names_value2'],
3160+
names=["names_value1", "names_value2"],
31623161
)
31633162
31643163
# Make the request

tests/integration/goldens/asset/noxfile.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,9 @@
3333
# and less concerned about the line length.
3434
LINT_LINE_LENGTH = 150
3535

36-
# Add samples to the list of directories to format if the directory exists.
36+
# Add samples to the list of directories to lint if the directory exists.
3737
if os.path.isdir("samples"):
3838
LINT_PATHS.append("samples")
39-
FORMAT_PATHS.append("samples")
4039

4140
ALL_PYTHON = [
4241
"3.7",

tests/integration/goldens/asset/samples/generated_samples/cloudasset_v1_generated_asset_service_analyze_iam_policy_async.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,4 +52,5 @@ async def sample_analyze_iam_policy():
5252
# Handle the response
5353
print(response)
5454

55+
5556
# [END cloudasset_v1_generated_AssetService_AnalyzeIamPolicy_async]

tests/integration/goldens/asset/samples/generated_samples/cloudasset_v1_generated_asset_service_analyze_iam_policy_longrunning_async.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,4 +60,5 @@ async def sample_analyze_iam_policy_longrunning():
6060
# Handle the response
6161
print(response)
6262

63+
6364
# [END cloudasset_v1_generated_AssetService_AnalyzeIamPolicyLongrunning_async]

tests/integration/goldens/asset/samples/generated_samples/cloudasset_v1_generated_asset_service_analyze_iam_policy_longrunning_sync.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,4 +60,5 @@ def sample_analyze_iam_policy_longrunning():
6060
# Handle the response
6161
print(response)
6262

63+
6364
# [END cloudasset_v1_generated_AssetService_AnalyzeIamPolicyLongrunning_sync]

0 commit comments

Comments
 (0)