From 7a5d44f37519aa3d3dea5205ac4ceafb696c7d91 Mon Sep 17 00:00:00 2001 From: Shubhangi Singh Date: Thu, 12 Jun 2025 04:20:56 +0000 Subject: [PATCH 1/4] adding default value --- google-apis-core/lib/google/apis/core/base_service.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/google-apis-core/lib/google/apis/core/base_service.rb b/google-apis-core/lib/google/apis/core/base_service.rb index d07278f553a..f626ed69d1d 100644 --- a/google-apis-core/lib/google/apis/core/base_service.rb +++ b/google-apis-core/lib/google/apis/core/base_service.rb @@ -376,7 +376,7 @@ def delete_resumable_upload(bucket, upload_id, options: nil) command = make_storage_upload_command(:delete, 'b/{bucket}/o', options) command.upload_id = upload_id command.params['bucket'] = bucket unless bucket.nil? - command.delete_upload = options[:delete_upload] unless options[:delete_upload].nil? + command.delete_upload = true execute_or_queue_command(command) end From e7b7ae6d7f00746ceb33a84f9c85b23206d69c60 Mon Sep 17 00:00:00 2001 From: Shubhangi Singh Date: Fri, 13 Jun 2025 10:22:25 +0000 Subject: [PATCH 2/4] try --- google-apis-core/lib/google/apis/core/base_service.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/google-apis-core/lib/google/apis/core/base_service.rb b/google-apis-core/lib/google/apis/core/base_service.rb index f626ed69d1d..5acab15a3fe 100644 --- a/google-apis-core/lib/google/apis/core/base_service.rb +++ b/google-apis-core/lib/google/apis/core/base_service.rb @@ -371,6 +371,7 @@ def restart_resumable_upload(bucket, upload_source, upload_id, options: nil) # Name of the bucket where the upload is being performed. # @param [IO, String] upload_id # unique id generated for an ongoing upload + def delete_resumable_upload(bucket, upload_id, options: nil) command = make_storage_upload_command(:delete, 'b/{bucket}/o', options) From 7f8bc153668fe50fd2e3c4ae4b6d37c4afdfe07d Mon Sep 17 00:00:00 2001 From: Shubhangi Singh Date: Fri, 13 Jun 2025 10:23:23 +0000 Subject: [PATCH 3/4] try --- google-apis-core/lib/google/apis/core/base_service.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/google-apis-core/lib/google/apis/core/base_service.rb b/google-apis-core/lib/google/apis/core/base_service.rb index 5acab15a3fe..f626ed69d1d 100644 --- a/google-apis-core/lib/google/apis/core/base_service.rb +++ b/google-apis-core/lib/google/apis/core/base_service.rb @@ -371,7 +371,6 @@ def restart_resumable_upload(bucket, upload_source, upload_id, options: nil) # Name of the bucket where the upload is being performed. # @param [IO, String] upload_id # unique id generated for an ongoing upload - def delete_resumable_upload(bucket, upload_id, options: nil) command = make_storage_upload_command(:delete, 'b/{bucket}/o', options) From 7d9a55d350f9a1db4a4c36cd2de548d95b13605a Mon Sep 17 00:00:00 2001 From: Shubhangi Singh Date: Mon, 16 Jun 2025 12:45:09 +0000 Subject: [PATCH 4/4] updating test --- google-apis-core/spec/google/apis/core/service_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/google-apis-core/spec/google/apis/core/service_spec.rb b/google-apis-core/spec/google/apis/core/service_spec.rb index 855c28cc7e1..22250d8a8b1 100644 --- a/google-apis-core/spec/google/apis/core/service_spec.rb +++ b/google-apis-core/spec/google/apis/core/service_spec.rb @@ -297,7 +297,7 @@ service.send( :delete_resumable_upload, bucket_name, upload_id, - options: { upload_chunk_size: 11, delete_upload: true } + options: { upload_chunk_size: 11} ) end