From 152f295d24071bf850b2d1c3ea21fb379494cbc6 Mon Sep 17 00:00:00 2001 From: mpeddada1 Date: Fri, 19 Dec 2025 03:05:23 +0000 Subject: [PATCH 1/5] impl(bigtable): remove deprecated AsyncRowReader header --- doc/v3-migration-guide.md | 8 ++++ google/cloud/bigtable/CMakeLists.txt | 1 - google/cloud/bigtable/async_row_reader.h | 45 ------------------- .../bigtable/google_cloud_cpp_bigtable.bzl | 1 - 4 files changed, 8 insertions(+), 47 deletions(-) delete mode 100644 google/cloud/bigtable/async_row_reader.h diff --git a/doc/v3-migration-guide.md b/doc/v3-migration-guide.md index 9ac6298d27609..bc8579ac5dc94 100644 --- a/doc/v3-migration-guide.md +++ b/doc/v3-migration-guide.md @@ -46,6 +46,14 @@ module which can be added to your `MODULE.bazel` file as a dependency. ### Bigtable +
+Removed bigtable::AsyncRowReader<>::NO_ROWS_LIMIT + + +AsyncRowReader::NO_ROWS_LIMIT has been removed. Please use RowReader::NO_ROWS_LIMIT` instead. + +
+ ### Pubsub ### Spanner diff --git a/google/cloud/bigtable/CMakeLists.txt b/google/cloud/bigtable/CMakeLists.txt index 7b751b0ba1bb5..d294576aed5f9 100644 --- a/google/cloud/bigtable/CMakeLists.txt +++ b/google/cloud/bigtable/CMakeLists.txt @@ -108,7 +108,6 @@ add_library( admin_client.h app_profile_config.cc app_profile_config.h - async_row_reader.h bound_query.cc bound_query.h bytes.cc diff --git a/google/cloud/bigtable/async_row_reader.h b/google/cloud/bigtable/async_row_reader.h deleted file mode 100644 index e899ad3c29439..0000000000000 --- a/google/cloud/bigtable/async_row_reader.h +++ /dev/null @@ -1,45 +0,0 @@ -// Copyright 2019 Google LLC -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// https://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -#ifndef GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_BIGTABLE_ASYNC_ROW_READER_H -#define GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_BIGTABLE_ASYNC_ROW_READER_H - -#include "google/cloud/bigtable/version.h" -#include - -namespace google { -namespace cloud { -namespace bigtable { -GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN - -/** - * @deprecated Please use `bigtable::RowReader::NO_ROWS_LIMIT` instead. - */ -template -class AsyncRowReader { - public: - /// Special value to be used as rows_limit indicating no limit. - GOOGLE_CLOUD_CPP_DEPRECATED( - "`AsyncRowReader<>::NO_ROWS_LIMIT` is deprecated. It is scheduled for " - "deletion on 2023-05-01. Please use `RowReader::NO_ROWS_LIMIT` instead.") - // NOLINTNEXTLINE(readability-identifier-naming) - static std::int64_t constexpr NO_ROWS_LIMIT = 0; -}; - -GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END -} // namespace bigtable -} // namespace cloud -} // namespace google - -#endif // GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_BIGTABLE_ASYNC_ROW_READER_H diff --git a/google/cloud/bigtable/google_cloud_cpp_bigtable.bzl b/google/cloud/bigtable/google_cloud_cpp_bigtable.bzl index c5d4f47beff0b..59b2c36e1e004 100644 --- a/google/cloud/bigtable/google_cloud_cpp_bigtable.bzl +++ b/google/cloud/bigtable/google_cloud_cpp_bigtable.bzl @@ -47,7 +47,6 @@ google_cloud_cpp_bigtable_hdrs = [ "admin/internal/bigtable_table_admin_tracing_stub.h", "admin_client.h", "app_profile_config.h", - "async_row_reader.h", "bound_query.h", "bytes.h", "cell.h", From 26c03c403f4d6ffd5c6497ab59abf0c80fe85093 Mon Sep 17 00:00:00 2001 From: mpeddada1 Date: Fri, 19 Dec 2025 03:15:52 +0000 Subject: [PATCH 2/5] fix checkers --- doc/v3-migration-guide.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/v3-migration-guide.md b/doc/v3-migration-guide.md index bc8579ac5dc94..5b69d5c65e743 100644 --- a/doc/v3-migration-guide.md +++ b/doc/v3-migration-guide.md @@ -50,7 +50,8 @@ module which can be added to your `MODULE.bazel` file as a dependency. Removed bigtable::AsyncRowReader<>::NO_ROWS_LIMIT -AsyncRowReader::NO_ROWS_LIMIT has been removed. Please use RowReader::NO_ROWS_LIMIT` instead. +AsyncRowReader::NO_ROWS_LIMIT has been removed. Please use +`google::cloud::bigtable::RowReader::NO_ROWS_LIMIT` instead. From 76dc60555e0544d44309d69fd49d26b56b4ccc2a Mon Sep 17 00:00:00 2001 From: mpeddada1 Date: Fri, 19 Dec 2025 03:48:25 +0000 Subject: [PATCH 3/5] fix formatting --- doc/v3-migration-guide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/v3-migration-guide.md b/doc/v3-migration-guide.md index 5b69d5c65e743..fc7f6205d3997 100644 --- a/doc/v3-migration-guide.md +++ b/doc/v3-migration-guide.md @@ -50,7 +50,7 @@ module which can be added to your `MODULE.bazel` file as a dependency. Removed bigtable::AsyncRowReader<>::NO_ROWS_LIMIT -AsyncRowReader::NO_ROWS_LIMIT has been removed. Please use +AsyncRowReader::NO_ROWS_LIMIT has been removed. Please use `google::cloud::bigtable::RowReader::NO_ROWS_LIMIT` instead. From 4eceb7302f4e4d49c8b0837574d63011af3abb88 Mon Sep 17 00:00:00 2001 From: mpeddada1 Date: Sat, 20 Dec 2025 02:48:34 +0000 Subject: [PATCH 4/5] add before and after --- doc/v3-migration-guide.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/doc/v3-migration-guide.md b/doc/v3-migration-guide.md index fc7f6205d3997..35f00d78ec99b 100644 --- a/doc/v3-migration-guide.md +++ b/doc/v3-migration-guide.md @@ -53,6 +53,14 @@ module which can be added to your `MODULE.bazel` file as a dependency. AsyncRowReader::NO_ROWS_LIMIT has been removed. Please use `google::cloud::bigtable::RowReader::NO_ROWS_LIMIT` instead. +```cpp +// Before +auto limit = google::cloud::bigtable::AsyncRowReader<>::NO_ROWS_LIMIT; + +// After +auto limit = google::cloud::bigtable::RowReader::NO_ROWS_LIMIT; +``` + ### Pubsub From a81afea75066739ab88d3f839c3e2b9d94795ecc Mon Sep 17 00:00:00 2001 From: mpeddada1 Date: Sat, 20 Dec 2025 02:56:17 +0000 Subject: [PATCH 5/5] run checkers --- doc/v3-migration-guide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/v3-migration-guide.md b/doc/v3-migration-guide.md index c5e66db801e5c..9421abcddc5fc 100644 --- a/doc/v3-migration-guide.md +++ b/doc/v3-migration-guide.md @@ -118,7 +118,7 @@ auto limit = google::cloud::bigtable::AsyncRowReader<>::NO_ROWS_LIMIT; // After auto limit = google::cloud::bigtable::RowReader::NO_ROWS_LIMIT; ``` - + ### Pubsub