chore(PubSub): Make logging safe in service.rb

Author: cy-yun

google-cloud-pubsub/lib/google/cloud/pubsub/logger_helper.rb

@@ -31,8 +31,6 @@ def self.logger name = ""
         end
       end
 
-      private 
-
       def self.is_logging_enabled
         packages = ENV["GOOGLE_SDK_RUBY_LOGGING"]&.split(",") || []
         packages.include?("pubsub") || packages.include?("all")
@@ -48,7 +46,17 @@ def log_batch logger_name, reason, type, num_messages, total_bytes
             "#{reason} triggered #{type} batch of #{num_messages} messages, a total of #{total_bytes} bytes"
           )
         end
-        
+
+        def log_ack_nack_safely ack_ids, type
+          return unless Google::Cloud::PubSub.is_logging_enabled
+          begin
+            ack_ids.each do |ack_id|
+              Google::Cloud::PubSub.logger("ack-nack").info "message (ackID #{ack_id}) #{type}"
+            end
+          rescue StandardError
+            # Ignore all logging errors.
+          end
+        end
       end
     end
   end

google-cloud-pubsub/lib/google/cloud/pubsub/service.rb

@@ -28,6 +28,8 @@ module PubSub
       ##
       # @private Represents the Pub/Sub service API, including IAM mixins.
       class Service
+        include LoggerHelper
+
         attr_accessor :project
         attr_accessor :credentials
         attr_accessor :host
@@ -142,9 +144,7 @@ def streaming_pull request_enum, options = {}
         ##
         # Acknowledges receipt of a message.
         def acknowledge subscription, *ack_ids
-          ack_ids.each do |ack_id|
-            Google::Cloud::PubSub.logger("ack-nack").info "message (ackID #{ack_id}) ack"
-          end
+          log_ack_nack_safely ack_ids, "ack"
           subscription_admin.acknowledge_internal subscription: subscription_path(subscription),
                                                   ack_ids: ack_ids
         end
@@ -153,9 +153,7 @@ def acknowledge subscription, *ack_ids
         # Modifies the ack deadline for a specific message.
         def modify_ack_deadline subscription, ids, deadline
           if deadline.zero?
-            Array(ids).each do |ack_id|
-              Google::Cloud::PubSub.logger("ack-nack").info "message (ackID #{ack_id}) nack"
-            end
+            log_ack_nack_safely Array(ids), "nack"
           end
           subscription_admin.modify_ack_deadline_internal subscription: subscription_path(subscription),
                                                           ack_ids: Array(ids),