From c3de65bcce9005cad2d037f013d5a50b0f6d0b1f Mon Sep 17 00:00:00 2001 From: Daniel Bruce Date: Thu, 13 Mar 2025 09:52:23 -0400 Subject: [PATCH 1/3] Add a comment --- test/chunktransformer.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/test/chunktransformer.ts b/test/chunktransformer.ts index d58a2d434..5e08c46de 100644 --- a/test/chunktransformer.ts +++ b/test/chunktransformer.ts @@ -39,6 +39,7 @@ const FakeMutation = { }), }; +// Some-comment describe('Bigtable/ChunkTransformer', () => { // eslint-disable-next-line @typescript-eslint/no-explicit-any let ChunkTransformer: any; From 817350f2642dcd8448a05b6d1088ebd98f121381 Mon Sep 17 00:00:00 2001 From: Daniel Bruce Date: Thu, 13 Mar 2025 11:50:06 -0400 Subject: [PATCH 2/3] Solve the compiler issue --- src/instance.ts | 2 +- src/table.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/instance.ts b/src/instance.ts index 7d5569bd5..420d9cbf5 100644 --- a/src/instance.ts +++ b/src/instance.ts @@ -1310,7 +1310,7 @@ Please use the format 'my-instance' or '${bigtable.projectName}/instances/my-ins : callback!; if (policy.etag !== null && policy.etag !== undefined) { - (policy.etag as {} as Buffer) = Buffer.from(policy.etag); + (policy.etag as {} as Buffer) = Buffer.from(policy.etag as string); } const reqOpts = { resource: this.name, diff --git a/src/table.ts b/src/table.ts index ea721b3ac..d59eaf0ca 100644 --- a/src/table.ts +++ b/src/table.ts @@ -1042,7 +1042,7 @@ export class Table extends TabularApiSurface { : callback!; if (policy.etag !== null && policy.etag !== undefined) { - (policy.etag as {} as Buffer) = Buffer.from(policy.etag); + (policy.etag as {} as Buffer) = Buffer.from(policy.etag as string); } const reqOpts = { resource: this.name, From 08d3a931d25b53a45889bdd60ef88b4f27ee2ea1 Mon Sep 17 00:00:00 2001 From: Daniel Bruce Date: Thu, 13 Mar 2025 11:51:29 -0400 Subject: [PATCH 3/3] Dowgrade promisify --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 2dc24800e..d94a5f3e5 100644 --- a/package.json +++ b/package.json @@ -51,7 +51,7 @@ "@google-cloud/opentelemetry-resource-util": "^2.4.0", "@google-cloud/precise-date": "^4.0.0", "@google-cloud/projectify": "^4.0.0", - "@google-cloud/promisify": "^4.0.0", + "@google-cloud/promisify": "4.0.0", "@opentelemetry/api": "^1.9.0", "@opentelemetry/resources": "^1.30.0", "@opentelemetry/sdk-metrics": "^1.30.0",