use single sleep iterator for retries

Author: daniel-sanche

google/api_core/retry/retry_base.py

@@ -25,7 +25,7 @@
 import time
 
 from enum import Enum
-from typing import Any, Callable, Optional, Iterable, TYPE_CHECKING
+from typing import Any, Callable, Optional, Iterator, TYPE_CHECKING
 
 import requests.exceptions
 
@@ -174,7 +174,7 @@ def build_retry_error(
 def _retry_error_helper(
     exc: Exception,
     deadline: float | None,
-    sleep_generator: Iterable[float],
+    sleep_generator: Iterator[float],
     error_list: list[Exception],
     predicate_fn: Callable[[Exception], bool],
     on_error_fn: Callable[[Exception], None] | None,

google/api_core/retry/retry_streaming.py

@@ -107,6 +107,7 @@ def retry_target_stream(
         time.monotonic() + timeout if timeout is not None else None
     )
     error_list: list[Exception] = []
+    sleep_iter = iter(sleep_generator)
 
     while True:
         # Start a new retry loop
@@ -124,7 +125,7 @@ def retry_target_stream(
             next_sleep = _retry_error_helper(
                 exc,
                 deadline,
-                sleep_generator,
+                sleep_iter,
                 error_list,
                 predicate,
                 on_error,

google/api_core/retry/retry_streaming_async.py

@@ -109,6 +109,7 @@ async def retry_target_stream(
     deadline = time.monotonic() + timeout if timeout else None
     # keep track of retryable exceptions we encounter to pass in to exception_factory
     error_list: list[Exception] = []
+    sleep_iter = iter(sleep_generator)
     target_is_generator: bool | None = None
 
     while True:
@@ -177,7 +178,7 @@ async def retry_target_stream(
             next_sleep = _retry_error_helper(
                 exc,
                 deadline,
-                sleep_generator,
+                sleep_iter,
                 error_list,
                 predicate,
                 on_error,

google/api_core/retry/retry_unary.py

@@ -138,6 +138,7 @@ def retry_target(
 
     deadline = time.monotonic() + timeout if timeout is not None else None
     error_list: list[Exception] = []
+    sleep_iter = iter(sleep_generator)
 
     while True:
         try:
@@ -153,7 +154,7 @@ def retry_target(
             next_sleep = _retry_error_helper(
                 exc,
                 deadline,
-                sleep_generator,
+                sleep_iter,
                 error_list,
                 predicate,
                 on_error,

google/api_core/retry/retry_unary_async.py

@@ -149,6 +149,7 @@ async def retry_target(
 
     deadline = time.monotonic() + timeout if timeout is not None else None
     error_list: list[Exception] = []
+    sleep_iter = iter(sleep_generator)
 
     while True:
         try:
@@ -160,7 +161,7 @@ async def retry_target(
             next_sleep = _retry_error_helper(
                 exc,
                 deadline,
-                sleep_generator,
+                sleep_iter,
                 error_list,
                 predicate,
                 on_error,