address PR feedback

Author: ohmayr

tests/asyncio/test_grpc_helpers_async.py

@@ -522,6 +522,9 @@ def test_create_channel_explicit_with_duplicate_credentials():
     target = "example:443"
 
     with pytest.raises(exceptions.DuplicateCredentialArgs) as excinfo:
+        # The `credentials_file` argument is deprecated by
+        # the Google Cloud Auth library (`google-auth`), which is the
+        # upstream dependency responsible for handling authentication.
         with pytest.warns(DeprecationWarning):
             grpc_helpers_async.create_channel(
                 target,
@@ -643,6 +646,9 @@ def test_create_channel_with_credentials_file(
     composite_creds = composite_creds_call.return_value
 
     with pytest.warns(DeprecationWarning):
+        # The `credentials_file` argument is deprecated by
+        # the Google Cloud Auth library (`google-auth`), which is the
+        # upstream dependency responsible for handling authentication.
         channel = grpc_helpers_async.create_channel(
             target, credentials_file=credentials_file
         )
@@ -673,6 +679,9 @@ def test_create_channel_with_credentials_file_and_scopes(
     composite_creds = composite_creds_call.return_value
 
     with pytest.warns(DeprecationWarning):
+        # The `credentials_file` argument is deprecated by
+        # the Google Cloud Auth library (`google-auth`), which is the
+        # upstream dependency responsible for handling authentication.        
         channel = grpc_helpers_async.create_channel(
             target, credentials_file=credentials_file, scopes=scopes
         )
@@ -703,6 +712,9 @@ def test_create_channel_with_credentials_file_and_default_scopes(
     composite_creds = composite_creds_call.return_value
 
     with pytest.warns(DeprecationWarning):
+        # The `credentials_file` argument is deprecated by
+        # the Google Cloud Auth library (`google-auth`), which is the
+        # upstream dependency responsible for handling authentication.
         channel = grpc_helpers_async.create_channel(
             target, credentials_file=credentials_file, default_scopes=default_scopes
         )

tests/unit/operations_v1/test_operations_rest_client.py

@@ -370,6 +370,9 @@ def test_operations_client_client_options(
 
     # Check the case credentials_file is provided
     with pytest.warns(DeprecationWarning):
+        # The `credentials_file` argument is deprecated by
+        # the Google Cloud Auth library (`google-auth`), which is the
+        # upstream dependency responsible for handling authentication.
         options = client_options.ClientOptions(credentials_file="credentials.json")
     with mock.patch.object(transport_class, "__init__") as patched:
         patched.return_value = None
@@ -541,6 +544,9 @@ def test_operations_client_client_options_credentials_file(
 ):
     # Check the case credentials file is provided.
     with pytest.warns(DeprecationWarning):
+        # The `credentials_file` argument is deprecated by
+        # the Google Cloud Auth library (`google-auth`), which is the
+        # upstream dependency responsible for handling authentication.
         options = client_options.ClientOptions(credentials_file="credentials.json")
     if "async" in str(client_class):
         with mock.patch.object(transport_class, "__init__") as patched:
@@ -584,6 +590,9 @@ def test_operations_client_client_options_credentials_file(
 def test_list_operations_rest(google_auth_default, credentials_file):
     if credentials_file is not None:
         with pytest.warns(DeprecationWarning):
+            # The `credentials_file` argument is deprecated by
+            # the Google Cloud Auth library (`google-auth`), which is the
+            # upstream dependency responsible for handling authentication.
             sync_transport = transports.rest.OperationsRestTransport(
                 credentials_file=credentials_file,
                 http_options=HTTP_OPTIONS,
@@ -1150,6 +1159,9 @@ def test_operations_base_transport_error():
     # Passing both a credentials object and credentials_file should raise an error
     with pytest.raises(core_exceptions.DuplicateCredentialArgs):
         with pytest.warns(DeprecationWarning):
+            # The `credentials_file` argument is deprecated by
+            # the Google Cloud Auth library (`google-auth`), which is the
+            # upstream dependency responsible for handling authentication.
             transports.OperationsTransport(
                 credentials=ga_credentials.AnonymousCredentials(),
                 credentials_file="credentials.json",
@@ -1192,6 +1204,9 @@ def test_operations_base_transport_with_credentials_file():
         Transport.return_value = None
         load_creds.return_value = (ga_credentials.AnonymousCredentials(), None)
         with pytest.warns(DeprecationWarning):
+            # The `credentials_file` argument is deprecated by
+            # the Google Cloud Auth library (`google-auth`), which is the
+            # upstream dependency responsible for handling authentication.
             transports.OperationsTransport(
                 credentials_file="credentials.json",
                 quota_project_id="octopus",

tests/unit/test_client_options.py

@@ -28,6 +28,9 @@ def get_client_encrypted_cert():
 
 def test_constructor():
     with pytest.warns(DeprecationWarning):
+        # The `credentials_file` argument is deprecated by
+        # the Google Cloud Auth library (`google-auth`), which is the
+        # upstream dependency responsible for handling authentication.
         options = client_options.ClientOptions(
             api_endpoint="foo.googleapis.com",
             client_cert_source=get_client_cert,
@@ -103,6 +106,9 @@ def test_constructor_with_api_key():
 def test_constructor_with_both_api_key_and_credentials_file():
     with pytest.raises(ValueError):
         with pytest.warns(DeprecationWarning):
+            # The `credentials_file` argument is deprecated by
+            # the Google Cloud Auth library (`google-auth`), which is the
+            # upstream dependency responsible for handling authentication.
             client_options.ClientOptions(
                 api_key="api-key",
                 credentials_file="path/to/credentials.json",

tests/unit/test_grpc_helpers.py

@@ -582,6 +582,9 @@ def test_create_channel_explicit_with_duplicate_credentials():
 
     with pytest.raises(exceptions.DuplicateCredentialArgs):
         with pytest.warns(DeprecationWarning):
+            # The `credentials_file` argument is deprecated by
+            # the Google Cloud Auth library (`google-auth`), which is the
+            # upstream dependency responsible for handling authentication.
             grpc_helpers.create_channel(
                 target,
                 credentials_file="credentials.json",
@@ -712,6 +715,9 @@ def test_create_channel_with_credentials_file(
     composite_creds = composite_creds_call.return_value
 
     with pytest.warns(DeprecationWarning):
+        # The `credentials_file` argument is deprecated by
+        # the Google Cloud Auth library (`google-auth`), which is the
+        # upstream dependency responsible for handling authentication.
         channel = grpc_helpers.create_channel(target, credentials_file=credentials_file)
 
     google.auth.load_credentials_from_file.assert_called_once_with(
@@ -745,6 +751,9 @@ def test_create_channel_with_credentials_file_and_scopes(
     composite_creds = composite_creds_call.return_value
 
     with pytest.warns(DeprecationWarning):
+        # The `credentials_file` argument is deprecated by
+        # the Google Cloud Auth library (`google-auth`), which is the
+        # upstream dependency responsible for handling authentication.
         channel = grpc_helpers.create_channel(
             target, credentials_file=credentials_file, scopes=scopes
         )
@@ -780,6 +789,9 @@ def test_create_channel_with_credentials_file_and_default_scopes(
     composite_creds = composite_creds_call.return_value
 
     with pytest.warns(DeprecationWarning):
+        # The `credentials_file` argument is deprecated by
+        # the Google Cloud Auth library (`google-auth`), which is the
+        # upstream dependency responsible for handling authentication.
         channel = grpc_helpers.create_channel(
             target, credentials_file=credentials_file, default_scopes=default_scopes
         )