address feedback

Author: parthea

google/api_core/_python_package_support.py

@@ -55,7 +55,7 @@
 UNKNOWN_VERSION_STRING = "--"
 
 
-def _parse_version_to_tuple(version_string: str) -> ParsedVersion:
+def parse_version_to_tuple(version_string: str) -> ParsedVersion:
     """Safely converts a semantic version string to a comparable tuple of integers.
 
     Example: "4.25.8" -> (4, 25, 8)
@@ -100,11 +100,11 @@ def get_dependency_version(
     """
     try:
         version_string: str = metadata.version(dependency_name)
-        parsed_version = _parse_version_to_tuple(version_string)
+        parsed_version = parse_version_to_tuple(version_string)
         return DependencyVersion(parsed_version, version_string)
     except Exception:
         # Catch exceptions from metadata.version() (e.g., PackageNotFoundError)
-        # or errors during _parse_version_to_tuple
+        # or errors during parse_version_to_tuple
         return DependencyVersion(None, UNKNOWN_VERSION_STRING)
 
 
@@ -158,7 +158,7 @@ def warn_deprecation_for_versions_less_than(
     if not dependency_version.version:
         return
 
-    if dependency_version.version < _parse_version_to_tuple(
+    if dependency_version.version < parse_version_to_tuple(
         minimum_fully_supported_version
     ):
         (

tests/unit/test_python_package_support.py

@@ -19,7 +19,7 @@
 import pytest
 
 from google.api_core._python_package_support import (
-    _parse_version_to_tuple,
+    parse_version_to_tuple,
     get_dependency_version,
     warn_deprecation_for_versions_less_than,
     check_dependency_versions,
@@ -42,7 +42,7 @@ def test_get_dependency_version(mocker, version_string_to_test):
             "importlib_metadata.version", return_value=version_string_to_test
         )
     expected = DependencyVersion(
-        _parse_version_to_tuple(version_string_to_test), version_string_to_test
+        parse_version_to_tuple(version_string_to_test), version_string_to_test
     )
     assert get_dependency_version("some-package") == expected
 
@@ -64,7 +64,7 @@ def test_warn_deprecation_for_versions_less_than(mock_get_version, mock_get_pack
     ]
 
     mock_get_version.return_value = DependencyVersion(
-        _parse_version_to_tuple("1.0.0"), "1.0.0"
+        parse_version_to_tuple("1.0.0"), "1.0.0"
     )
     with pytest.warns(FutureWarning) as record:
         warn_deprecation_for_versions_less_than("my.package", "dep.package", "2.0.0")
@@ -81,14 +81,14 @@ def test_warn_deprecation_for_versions_less_than(mock_get_version, mock_get_pack
         # Case 2: Installed version is equal to required, should not warn.
         mock_get_packages.reset_mock()
         mock_get_version.return_value = DependencyVersion(
-            _parse_version_to_tuple("2.0.0"), "2.0.0"
+            parse_version_to_tuple("2.0.0"), "2.0.0"
         )
         warn_deprecation_for_versions_less_than("my.package", "dep.package", "2.0.0")
 
         # Case 3: Installed version is greater than required, should not warn.
         mock_get_packages.reset_mock()
         mock_get_version.return_value = DependencyVersion(
-            _parse_version_to_tuple("3.0.0"), "3.0.0"
+            parse_version_to_tuple("3.0.0"), "3.0.0"
         )
         warn_deprecation_for_versions_less_than("my.package", "dep.package", "2.0.0")
 
@@ -107,7 +107,7 @@ def test_warn_deprecation_for_versions_less_than(mock_get_version, mock_get_pack
         ("my-package (my.package)", "my-package"),
     ]
     mock_get_version.return_value = DependencyVersion(
-        _parse_version_to_tuple("1.0.0"), "1.0.0"
+        parse_version_to_tuple("1.0.0"), "1.0.0"
     )
     template = "Custom warning for {dependency_package} used by {consumer_package}."
     with pytest.warns(FutureWarning) as record: