Skip to content

Commit 8d19eb2

Browse files
committed
refactor: make fake past and future versions into constants
1 parent a254693 commit 8d19eb2

File tree

1 file changed

+16
-14
lines changed

1 file changed

+16
-14
lines changed

google/api_core/_python_version_support.py

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,20 @@ class VersionInfo(NamedTuple):
123123

124124

125125
LOWEST_TRACKED_VERSION = min(PYTHON_VERSION_INFO.keys())
126-
FAKE_PAST_DATE = datetime.date.min + datetime.timedelta(days=900)
127-
FAKE_FUTURE_DATE = datetime.date.max - datetime.timedelta(days=900)
126+
_FAKE_PAST_DATE = datetime.date.min + datetime.timedelta(days=900)
127+
_FAKE_PAST_VERSION = VersionInfo(
128+
version="0.0",
129+
python_beta=_FAKE_PAST_DATE,
130+
python_start=_FAKE_PAST_DATE,
131+
python_eol=_FAKE_PAST_DATE,
132+
)
133+
_FAKE_FUTURE_DATE = datetime.date.max - datetime.timedelta(days=900)
134+
_FAKE_FUTURE_VERSION = VersionInfo(
135+
version="999.0",
136+
python_beta=_FAKE_FUTURE_DATE,
137+
python_start=_FAKE_FUTURE_DATE,
138+
python_eol=_FAKE_FUTURE_DATE,
139+
)
128140
DEPRECATION_WARNING_PERIOD = datetime.timedelta(days=365)
129141
EOL_GRACE_PERIOD = datetime.timedelta(weeks=1)
130142

@@ -195,19 +207,9 @@ def check_python_version(
195207

196208
if not version_info:
197209
if version_tuple < LOWEST_TRACKED_VERSION:
198-
version_info = VersionInfo(
199-
version="0.0",
200-
python_beta=FAKE_PAST_DATE,
201-
python_start=FAKE_PAST_DATE,
202-
python_eol=FAKE_PAST_DATE,
203-
)
210+
version_info = _FAKE_PAST_VERSION
204211
else:
205-
version_info = VersionInfo(
206-
version="999.0",
207-
python_beta=FAKE_FUTURE_DATE,
208-
python_start=FAKE_FUTURE_DATE,
209-
python_eol=FAKE_FUTURE_DATE,
210-
)
212+
version_info = _FAKE_FUTURE_VERSION
211213

212214
gapic_deprecation = version_info.gapic_deprecation or (
213215
version_info.python_eol - DEPRECATION_WARNING_PERIOD

0 commit comments

Comments
 (0)