move stop call to within the exception clauses

Author: abbrowne126

google/api_core/bidi.py

@@ -676,15 +676,16 @@ def _thread_main(self, ready):
                 exc,
                 exc_info=True,
             )
+            self.stop()
 
         except Exception as exc:
             _LOGGER.exception(
                 "%s caught unexpected exception %s and will exit.",
                 _BIDIRECTIONAL_CONSUMER_NAME,
                 exc,
             )
+            self.stop()
 
-        self.stop()
         _LOGGER.info("%s exiting", _BIDIRECTIONAL_CONSUMER_NAME)
 
     def start(self):

tests/unit/test_bidi.py

@@ -926,7 +926,7 @@ def test_fatal_exceptions_will_shutdown_consumer(self, caplog):
       lead to the consumer halting should also stop the thread and rpc.
       """
       caplog.set_level(logging.DEBUG)
-      bidi_rpc = mock.create_autospec(bidi.BidiRpc, instance=True)
+      bidi_rpc = mock.create_autospec(bidi.ResumableBidiRpc, instance=True)
       bidi_rpc.is_active = True
       on_response = mock.Mock(spec=["__call__"])