Skip to content

Commit 081de7a

Browse files
committed
resolve the comments
1 parent 1d3b0d4 commit 081de7a

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

bigframes/functions/_utils.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def _get_updated_package_requirements(
8181
msg = bfe.format_message(
8282
"Numpy, Pandas, and Pyarrow version may not precisely match your local environment."
8383
)
84-
warnings.warn(msg, category=bfe.PreviewWarning)
84+
warnings.warn(msg, category=bfe.FunctionPackageVersionWarning)
8585
requirements.append("pandas")
8686
requirements.append("pyarrow")
8787
requirements.append("numpy")
@@ -94,6 +94,8 @@ def _get_updated_package_requirements(
9494
requirements.append(f"pyarrow=={pyarrow.__version__}")
9595
requirements.append(f"numpy=={numpy.__version__}")
9696

97+
# TODO(b/435023957): Fix the issue of potential duplicate package versions
98+
# when `package_requirements` also contains `pandas/pyarrow/numpy`.
9799
if package_requirements:
98100
requirements.extend(package_requirements)
99101

tests/system/large/functions/test_managed_function.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -714,9 +714,9 @@ def test_managed_function_df_apply_axis_1_aggregates(session, dataset_id, scalar
714714
try:
715715

716716
def analyze(row):
717-
# TODO(b/435021126): Remove explicit type conversion of the field
718-
# "name" after the issue has been addressed. It is added only to
719-
# accept partial pandas parity for the time being.
717+
# TODO(b/435021126): Remove explicit type conversion of the fields
718+
# after the issue has been addressed. It is added only to accept
719+
# partial pandas parity for the time being.
720720
return str(
721721
{
722722
"dtype": row.dtype,
@@ -730,7 +730,7 @@ def analyze(row):
730730
)
731731

732732
with pytest.warns(
733-
bfe.PreviewWarning,
733+
bfe.FunctionPackageVersionWarning,
734734
match=("Numpy, Pandas, and Pyarrow version may not precisely match."),
735735
):
736736

0 commit comments

Comments
 (0)