Skip to content

Commit 0fdd566

Browse files
fixup impl errors
1 parent 1eb20bb commit 0fdd566

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

bigframes/core/groupby/dataframe_group_by.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -748,22 +748,22 @@ def _apply_window_op(
748748
window_spec = window or window_specs.cumulative_rows(
749749
grouping_keys=tuple(self._by_col_ids)
750750
)
751-
columns, _ = self._aggregated_columns(numeric_only=numeric_only)
751+
columns, labels = self._aggregated_columns(numeric_only=numeric_only)
752752
block, result_ids = self._block.multi_apply_window_op(
753753
columns,
754754
op,
755755
window_spec=window_spec,
756756
)
757-
block = self._block.project_exprs(
757+
block = block.project_exprs(
758758
tuple(
759759
bigframes.operations.where_op.as_expr(
760-
bigframes.operations.notnull_op.as_expr(og_col),
761760
r_col,
761+
bigframes.operations.notnull_op.as_expr(og_col),
762762
ex.const(None),
763763
)
764764
for og_col, r_col in zip(columns, result_ids)
765765
),
766-
labels=block.column_labels,
766+
labels=labels,
767767
drop=True,
768768
)
769769

bigframes/core/groupby/series_group_by.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -440,10 +440,10 @@ def _apply_window_op(
440440
window_spec=window_spec,
441441
)
442442
if op.skips_nulls:
443-
block, result_id = self._block.project_expr(
443+
block, result_id = block.project_expr(
444444
bigframes.operations.where_op.as_expr(
445-
bigframes.operations.notnull_op.as_expr(self._value_column),
446445
result_id,
446+
bigframes.operations.notnull_op.as_expr(self._value_column),
447447
ex.const(None),
448448
),
449449
label,

bigframes/dataframe.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4160,16 +4160,16 @@ def _apply_window_op(
41604160
window_spec=window_spec,
41614161
)
41624162
if op.skips_nulls:
4163-
block = self._block.project_exprs(
4163+
block = block.project_exprs(
41644164
tuple(
41654165
bigframes.operations.where_op.as_expr(
4166-
bigframes.operations.notnull_op.as_expr(og_col),
41674166
r_col,
4167+
bigframes.operations.notnull_op.as_expr(og_col),
41684168
ex.const(None),
41694169
)
41704170
for og_col, r_col in zip(self._block.value_columns, result_ids)
41714171
),
4172-
labels=block.column_labels,
4172+
labels=self._block.column_labels,
41734173
drop=True,
41744174
)
41754175
else:

0 commit comments

Comments
 (0)