dense_rank and rank doesn't support window framing clauses

Author: chelsea-lin

bigframes/core/compile/sqlglot/aggregations/windows.py

@@ -64,6 +64,25 @@ def apply_window_if_present(
     if not window.bounds and not order:
         return sge.Window(this=value, partition_by=group_by)
 
+    # Ranking and navigation functions do not support window framing clauses.
+    # See: https://cloud.google.com/bigquery/docs/reference/standard-sql/analytic-function-concepts#window-frame-clause
+    no_frame_functions = {
+        "RANK",
+        "DENSE_RANK",
+        "NTILE",
+        "PERCENT_RANK",
+        "CUME_DIST",
+        "ROW_NUMBER",
+        "LAG",
+        "LEAD",
+        "FIRST_VALUE",
+        "LAST_VALUE",
+        "NTH_VALUE",
+    }
+    func_name = value.sql_name().upper() if isinstance(value, sge.Func) else ""
+    if not window.bounds and func_name in no_frame_functions:
+        return sge.Window(this=value, partition_by=group_by, order=order)
+
     kind = (
         "ROWS" if isinstance(window.bounds, window_spec.RowsWindowBounds) else "RANGE"
     )

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_unary_compiler/test_dense_rank/out.sql

@@ -6,10 +6,7 @@ WITH `bfcte_0` AS (
 ), `bfcte_1` AS (
   SELECT
     *,
-    DENSE_RANK() OVER (
-      ORDER BY `bfcol_0` IS NULL ASC NULLS LAST, `bfcol_0` ASC NULLS LAST
-      RANGE BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING
-    ) AS `bfcol_4`
+    DENSE_RANK() OVER (ORDER BY `bfcol_0` IS NULL ASC NULLS LAST, `bfcol_0` ASC NULLS LAST) AS `bfcol_4`
   FROM `bfcte_0`
 )
 SELECT