snapshot again

Author: tswast

bigframes/core/array_value.py

@@ -141,11 +141,6 @@ def from_bq_data_source(
         )
         return cls(node)
 
-    @staticmethod
-    def is_table_type_supported(table_type: Optional[str]):
-        # Some external tables like those in GCS support all the features we want, such as time travel.
-        return table_type in ("TABLE", "MATERIALIZED_VIEW", "EXTERNAL")
-
     @property
     def column_ids(self) -> typing.Sequence[str]:
         """Returns column ids as strings."""

bigframes/session/_io/bigquery/read_gbq_table.py

@@ -28,6 +28,7 @@
 import google.cloud.bigquery as bigquery
 import google.cloud.bigquery.table
 
+import bigframes.core
 import bigframes.core.events
 import bigframes.exceptions as bfe
 import bigframes.session._io.bigquery

bigframes/session/loader.py

@@ -709,9 +709,9 @@ def read_gbq_table(
             # the index is consistent with tables that have primary keys, even
             # when max_results is set.
             max_results is not None
-            # Views such as INFORMATION_SCHEMA also introduce non-determinism.
+            # Views such as INFORMATION_SCHEMA can introduce non-determinism.
             # They can update frequently and don't support time travel.
-            or not core.ArrayValue.is_table_type_supported(table.table_type)
+            or bf_read_gbq_table.is_information_schema(table_id)
         ):
             # TODO(b/338111344): If we are running a query anyway, we might as
             # well generate ROW_NUMBER() at the same time.

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_binary_compiler/test_corr/out.sql

@@ -1,7 +1,8 @@
 WITH `bfcte_0` AS (
   SELECT
-    *
-  FROM UNNEST(ARRAY<STRUCT<`bfcol_0` INT64, `bfcol_1` FLOAT64>>[STRUCT(CAST(NULL AS INT64), CAST(NULL AS FLOAT64))])
+    `int64_col` AS `bfcol_0`,
+    `float64_col` AS `bfcol_1`
+  FROM `bigframes-dev`.`sqlglot_test`.`scalar_types`
 ), `bfcte_1` AS (
   SELECT
     CORR(`bfcol_0`, `bfcol_1`) AS `bfcol_2`

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_binary_compiler/test_cov/out.sql

@@ -1,7 +1,8 @@
 WITH `bfcte_0` AS (
   SELECT
-    *
-  FROM UNNEST(ARRAY<STRUCT<`bfcol_0` INT64, `bfcol_1` FLOAT64>>[STRUCT(CAST(NULL AS INT64), CAST(NULL AS FLOAT64))])
+    `int64_col` AS `bfcol_0`,
+    `float64_col` AS `bfcol_1`
+  FROM `bigframes-dev`.`sqlglot_test`.`scalar_types`
 ), `bfcte_1` AS (
   SELECT
     COVAR_SAMP(`bfcol_0`, `bfcol_1`) AS `bfcol_2`

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_nullary_compiler/test_row_number/out.sql

@@ -1,15 +1,27 @@
 WITH `bfcte_0` AS (
   SELECT
-    *
-  FROM UNNEST(ARRAY<STRUCT<`bfcol_0` BOOLEAN, `bfcol_1` INT64>>[STRUCT(CAST(NULL AS BOOLEAN), 0)])
+    `bool_col` AS `bfcol_0`,
+    `bytes_col` AS `bfcol_1`,
+    `date_col` AS `bfcol_2`,
+    `datetime_col` AS `bfcol_3`,
+    `geography_col` AS `bfcol_4`,
+    `int64_col` AS `bfcol_5`,
+    `int64_too` AS `bfcol_6`,
+    `numeric_col` AS `bfcol_7`,
+    `float64_col` AS `bfcol_8`,
+    `rowindex` AS `bfcol_9`,
+    `rowindex_2` AS `bfcol_10`,
+    `string_col` AS `bfcol_11`,
+    `time_col` AS `bfcol_12`,
+    `timestamp_col` AS `bfcol_13`,
+    `duration_col` AS `bfcol_14`
+  FROM `bigframes-dev`.`sqlglot_test`.`scalar_types`
 ), `bfcte_1` AS (
   SELECT
     *,
-    ROW_NUMBER() OVER (ORDER BY `bfcol_1` ASC NULLS LAST) AS `bfcol_3`
+    ROW_NUMBER() OVER () AS `bfcol_32`
   FROM `bfcte_0`
 )
 SELECT
-  `bfcol_3` AS `row_number`
-FROM `bfcte_1`
-ORDER BY
-  `bfcol_1` ASC NULLS LAST
+  `bfcol_32` AS `row_number`
+FROM `bfcte_1`

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_nullary_compiler/test_row_number_with_window/out.sql

@@ -1,15 +1,13 @@
 WITH `bfcte_0` AS (
   SELECT
-    *
-  FROM UNNEST(ARRAY<STRUCT<`bfcol_0` INT64, `bfcol_1` INT64>>[STRUCT(CAST(NULL AS INT64), 0)])
+    `int64_col` AS `bfcol_0`
+  FROM `bigframes-dev`.`sqlglot_test`.`scalar_types`
 ), `bfcte_1` AS (
   SELECT
     *,
-    ROW_NUMBER() OVER (ORDER BY `bfcol_0` ASC NULLS LAST, `bfcol_1` ASC NULLS LAST) AS `bfcol_2`
+    ROW_NUMBER() OVER (ORDER BY `bfcol_0` ASC NULLS LAST) AS `bfcol_1`
   FROM `bfcte_0`
 )
 SELECT
-  `bfcol_2` AS `row_number`
-FROM `bfcte_1`
-ORDER BY
-  `bfcol_1` ASC NULLS LAST
+  `bfcol_1` AS `row_number`
+FROM `bfcte_1`

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_nullary_compiler/test_size/out.sql

@@ -1,23 +1,21 @@
 WITH `bfcte_0` AS (
   SELECT
-    *
-  FROM UNNEST(ARRAY<STRUCT<`bfcol_0` BOOLEAN, `bfcol_1` BYTES, `bfcol_2` DATE, `bfcol_3` DATETIME, `bfcol_4` GEOGRAPHY, `bfcol_5` INT64, `bfcol_6` INT64, `bfcol_7` NUMERIC, `bfcol_8` FLOAT64, `bfcol_9` INT64, `bfcol_10` INT64, `bfcol_11` STRING, `bfcol_12` TIME, `bfcol_13` TIMESTAMP, `bfcol_14` INT64>>[STRUCT(
-    CAST(NULL AS BOOLEAN),
-    CAST(NULL AS BYTES),
-    CAST(NULL AS DATE),
-    CAST(NULL AS DATETIME),
-    CAST(NULL AS GEOGRAPHY),
-    CAST(NULL AS INT64),
-    CAST(NULL AS INT64),
-    CAST(NULL AS NUMERIC),
-    CAST(NULL AS FLOAT64),
-    CAST(NULL AS INT64),
-    CAST(NULL AS INT64),
-    CAST(NULL AS STRING),
-    CAST(NULL AS TIME),
-    CAST(NULL AS TIMESTAMP),
-    CAST(NULL AS INT64)
-  )])
+    `bool_col` AS `bfcol_0`,
+    `bytes_col` AS `bfcol_1`,
+    `date_col` AS `bfcol_2`,
+    `datetime_col` AS `bfcol_3`,
+    `geography_col` AS `bfcol_4`,
+    `int64_col` AS `bfcol_5`,
+    `int64_too` AS `bfcol_6`,
+    `numeric_col` AS `bfcol_7`,
+    `float64_col` AS `bfcol_8`,
+    `rowindex` AS `bfcol_9`,
+    `rowindex_2` AS `bfcol_10`,
+    `string_col` AS `bfcol_11`,
+    `time_col` AS `bfcol_12`,
+    `timestamp_col` AS `bfcol_13`,
+    `duration_col` AS `bfcol_14`
+  FROM `bigframes-dev`.`sqlglot_test`.`scalar_types`
 ), `bfcte_1` AS (
   SELECT
     COUNT(1) AS `bfcol_32`

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_ordered_unary_compiler/test_array_agg/out.sql

@@ -1,14 +1,12 @@
 WITH `bfcte_0` AS (
   SELECT
-    *
-  FROM UNNEST(ARRAY<STRUCT<`bfcol_0` INT64, `bfcol_1` INT64>>[STRUCT(CAST(NULL AS INT64), 0)])
+    `int64_col` AS `bfcol_0`
+  FROM `bigframes-dev`.`sqlglot_test`.`scalar_types`
 ), `bfcte_1` AS (
   SELECT
-    ARRAY_AGG(
-      `bfcol_0` IGNORE NULLS ORDER BY `bfcol_0` IS NULL ASC, `bfcol_0` ASC, `bfcol_1` IS NULL ASC, `bfcol_1` ASC
-    ) AS `bfcol_2`
+    ARRAY_AGG(`bfcol_0` IGNORE NULLS ORDER BY `bfcol_0` IS NULL ASC, `bfcol_0` ASC) AS `bfcol_1`
   FROM `bfcte_0`
 )
 SELECT
-  `bfcol_2` AS `int64_col`
+  `bfcol_1` AS `int64_col`
 FROM `bfcte_1`

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_ordered_unary_compiler/test_string_agg/out.sql

@@ -1,22 +1,15 @@
 WITH `bfcte_0` AS (
   SELECT
-    *
-  FROM UNNEST(ARRAY<STRUCT<`bfcol_0` STRING, `bfcol_1` INT64>>[STRUCT(CAST(NULL AS STRING), 0)])
+    `string_col` AS `bfcol_0`
+  FROM `bigframes-dev`.`sqlglot_test`.`scalar_types`
 ), `bfcte_1` AS (
   SELECT
-    COALESCE(
-      STRING_AGG(
-        `bfcol_0`, ','
-        ORDER BY
-          `bfcol_0` IS NULL ASC,
-          `bfcol_0` ASC,
-          `bfcol_1` IS NULL ASC,
-          `bfcol_1` ASC
-      ),
-      ''
-    ) AS `bfcol_2`
+    COALESCE(STRING_AGG(`bfcol_0`, ','
+    ORDER BY
+      `bfcol_0` IS NULL ASC,
+      `bfcol_0` ASC), '') AS `bfcol_1`
   FROM `bfcte_0`
 )
 SELECT
-  `bfcol_2` AS `string_col`
+  `bfcol_1` AS `string_col`
 FROM `bfcte_1`