Skip to content

Commit 42ec975

Browse files
committed
add TODO for some ops
1 parent c6e277e commit 42ec975

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

bigframes/core/compile/sqlglot/expressions/unary_compiler.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ def _(op: ops.base_ops.UnaryOp, expr: TypedExpr) -> sge.Expression:
107107

108108
@UNARY_OP_REGISTRATION.register(ops.AsTypeOp)
109109
def _(op: ops.AsTypeOp, expr: TypedExpr) -> sge.Expression:
110+
# TODO: Support more types for casting, such as JSON, etc.
110111
return sge.Cast(this=expr.expr, to=op.to_type)
111112

112113

@@ -241,6 +242,7 @@ def _(op: ops.base_ops.UnaryOp, expr: TypedExpr) -> sge.Expression:
241242

242243
@UNARY_OP_REGISTRATION.register(ops.FloorDtOp)
243244
def _(op: ops.FloorDtOp, expr: TypedExpr) -> sge.Expression:
245+
# TODO: Remove this method when it is covered by ops.FloorOp
244246
return sge.TimestampTrunc(this=expr.expr, unit=sge.Identifier(this=op.freq))
245247

246248

0 commit comments

Comments
 (0)