address comments

Author: chelsea-lin

bigframes/core/compile/sqlglot/aggregations/nullary_compiler.py

@@ -20,7 +20,7 @@
 
 from bigframes.core import window_spec
 import bigframes.core.compile.sqlglot.aggregations.op_registration as reg
-from bigframes.core.compile.sqlglot.aggregations.window import apply_window_if_present
+from bigframes.core.compile.sqlglot.aggregations.windows import apply_window_if_present
 from bigframes.operations import aggregations as agg_ops
 
 NULLARY_OP_REGISTRATION = reg.OpRegistration()

bigframes/core/compile/sqlglot/aggregations/unary_compiler.py

@@ -20,7 +20,7 @@
 
 from bigframes.core import window_spec
 import bigframes.core.compile.sqlglot.aggregations.op_registration as reg
-from bigframes.core.compile.sqlglot.aggregations.window import apply_window_if_present
+from bigframes.core.compile.sqlglot.aggregations.windows import apply_window_if_present
 import bigframes.core.compile.sqlglot.expressions.typed_expr as typed_expr
 import bigframes.core.compile.sqlglot.sqlglot_ir as ir
 from bigframes.operations import aggregations as agg_ops

…e/compile/sqlglot/aggregations/window.py …/compile/sqlglot/aggregations/windows.pybigframes/core/compile/sqlglot/aggregations/window.py renamed to bigframes/core/compile/sqlglot/aggregations/windows.py bigframes/core/compile/sqlglot/aggregations/window.py renamed to bigframes/core/compile/sqlglot/aggregations/windows.py

@@ -76,8 +76,8 @@ def apply_window_if_present(
         start = window.bounds.start
         end = window.bounds.end
 
-    start_value, start_side = _get_window_bounds(start, is_start_bounds=True)
-    end_value, end_side = _get_window_bounds(end, is_start_bounds=False)
+    start_value, start_side = _get_window_bounds(start, is_preceding=True)
+    end_value, end_side = _get_window_bounds(end, is_preceding=False)
 
     spec = sge.WindowSpec(
         kind=kind,
@@ -139,11 +139,11 @@ def get_window_order_by(
 
 
 def _get_window_bounds(
-    value, is_start_bounds: bool
+    value, is_preceding: bool
 ) -> tuple[typing.Union[str, sge.Expression], typing.Optional[str]]:
     """Compiles a single boundary value into its SQL components."""
     if value is None:
-        side = "PRECEDING" if is_start_bounds else "FOLLOWING"
+        side = "PRECEDING" if is_preceding else "FOLLOWING"
         return "UNBOUNDED", side
 
     if value == 0:

bigframes/core/compile/sqlglot/compiler.py

@@ -23,7 +23,7 @@
 from bigframes.core import expression, guid, identifiers, nodes, pyarrow_utils, rewrite
 from bigframes.core.compile import configs
 import bigframes.core.compile.sqlglot.aggregate_compiler as aggregate_compiler
-from bigframes.core.compile.sqlglot.aggregations import window
+from bigframes.core.compile.sqlglot.aggregations import windows
 from bigframes.core.compile.sqlglot.expressions import typed_expr
 import bigframes.core.compile.sqlglot.scalar_compiler as scalar_compiler
 import bigframes.core.compile.sqlglot.sqlglot_ir as ir
@@ -273,7 +273,7 @@ def compile_random_sample(
     def compile_aggregate(
         self, node: nodes.AggregateNode, child: ir.SQLGlotIR
     ) -> ir.SQLGlotIR:
-        ordering_cols = window.get_window_order_by(
+        ordering_cols = windows.get_window_order_by(
             node.order_by, override_null_order=True
         )
         aggregations: tuple[tuple[str, sge.Expression], ...] = tuple(

…pile/sqlglot/aggregations/test_window.py …ile/sqlglot/aggregations/test_windows.pytests/unit/core/compile/sqlglot/aggregations/test_window.py renamed to tests/unit/core/compile/sqlglot/aggregations/test_windows.py tests/unit/core/compile/sqlglot/aggregations/test_window.py renamed to tests/unit/core/compile/sqlglot/aggregations/test_windows.py

@@ -19,15 +19,15 @@
 import sqlglot.expressions as sge
 
 from bigframes.core import window_spec
-from bigframes.core.compile.sqlglot.aggregations.window import (
+from bigframes.core.compile.sqlglot.aggregations.windows import (
     apply_window_if_present,
     get_window_order_by,
 )
 import bigframes.core.expression as ex
 import bigframes.core.ordering as ordering
 
 
-class WindowTest(unittest.TestCase):
+class WindowsTest(unittest.TestCase):
     def test_get_window_order_by_empty(self):
         self.assertIsNone(get_window_order_by(tuple()))