test: update ordering spec on asc/desc and nulls_last

Author: chelsea-lin

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_unary_compiler/test_dense_rank/out.sql

@@ -5,7 +5,7 @@ WITH `bfcte_0` AS (
 ), `bfcte_1` AS (
   SELECT
     *,
-    DENSE_RANK() OVER (ORDER BY `bfcol_0` IS NULL ASC NULLS LAST, `bfcol_0` ASC NULLS LAST) AS `bfcol_1`
+    DENSE_RANK() OVER (ORDER BY `bfcol_0` DESC) AS `bfcol_1`
   FROM `bfcte_0`
 )
 SELECT

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_unary_compiler/test_diff/diff_bool.sql

@@ -5,7 +5,7 @@ WITH `bfcte_0` AS (
 ), `bfcte_1` AS (
   SELECT
     *,
-    `bfcol_0` <> LAG(`bfcol_0`, 1) OVER (ORDER BY `bfcol_0` IS NULL ASC NULLS LAST, `bfcol_0` ASC NULLS LAST) AS `bfcol_1`
+    `bfcol_0` <> LAG(`bfcol_0`, 1) OVER (ORDER BY `bfcol_0` DESC) AS `bfcol_1`
   FROM `bfcte_0`
 )
 SELECT

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_unary_compiler/test_first/out.sql

@@ -8,10 +8,7 @@ WITH `bfcte_0` AS (
     CASE
       WHEN `bfcol_0` IS NULL
       THEN NULL
-      ELSE FIRST_VALUE(`bfcol_0`) OVER (
-        ORDER BY `bfcol_0` IS NULL ASC NULLS LAST, `bfcol_0` ASC NULLS LAST
-        ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING
-      )
+      ELSE FIRST_VALUE(`bfcol_0`) OVER (ORDER BY `bfcol_0` DESC ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING)
     END AS `bfcol_1`
   FROM `bfcte_0`
 )

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_unary_compiler/test_last/out.sql

@@ -8,10 +8,7 @@ WITH `bfcte_0` AS (
     CASE
       WHEN `bfcol_0` IS NULL
       THEN NULL
-      ELSE LAST_VALUE(`bfcol_0`) OVER (
-        ORDER BY `bfcol_0` IS NULL ASC NULLS LAST, `bfcol_0` ASC NULLS LAST
-        ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING
-      )
+      ELSE LAST_VALUE(`bfcol_0`) OVER (ORDER BY `bfcol_0` DESC ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING)
     END AS `bfcol_1`
   FROM `bfcte_0`
 )

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_unary_compiler/test_rank/out.sql

@@ -5,7 +5,7 @@ WITH `bfcte_0` AS (
 ), `bfcte_1` AS (
   SELECT
     *,
-    RANK() OVER (ORDER BY `bfcol_0` IS NULL ASC NULLS LAST, `bfcol_0` ASC NULLS LAST) AS `bfcol_1`
+    RANK() OVER (ORDER BY `bfcol_0` IS NULL DESC NULLS FIRST, `bfcol_0` DESC NULLS FIRST) AS `bfcol_1`
   FROM `bfcte_0`
 )
 SELECT

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_unary_compiler/test_shift/lag.sql

@@ -5,7 +5,7 @@ WITH `bfcte_0` AS (
 ), `bfcte_1` AS (
   SELECT
     *,
-    LAG(`bfcol_0`, 1) OVER (ORDER BY `bfcol_0` IS NULL ASC NULLS LAST, `bfcol_0` ASC NULLS LAST) AS `bfcol_1`
+    LAG(`bfcol_0`, 1) OVER (ORDER BY `bfcol_0` ASC) AS `bfcol_1`
   FROM `bfcte_0`
 )
 SELECT

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_unary_compiler/test_shift/lead.sql

@@ -5,7 +5,7 @@ WITH `bfcte_0` AS (
 ), `bfcte_1` AS (
   SELECT
     *,
-    LEAD(`bfcol_0`, 1) OVER (ORDER BY `bfcol_0` IS NULL ASC NULLS LAST, `bfcol_0` ASC NULLS LAST) AS `bfcol_1`
+    LEAD(`bfcol_0`, 1) OVER (ORDER BY `bfcol_0` ASC) AS `bfcol_1`
   FROM `bfcte_0`
 )
 SELECT

tests/unit/core/compile/sqlglot/aggregations/test_unary_compiler.py

@@ -80,7 +80,7 @@ def test_all(scalar_types_df: bpd.DataFrame, snapshot):
     bf_df_str = scalar_types_df[[col_name, "string_col"]]
     window_partition = window_spec.WindowSpec(
         grouping_keys=(expression.deref("string_col"),),
-        ordering=(ordering.ascending_over(col_name),),
+        ordering=(ordering.descending_over(col_name),),
     )
     sql_window_partition = _apply_unary_window_op(
         bf_df_str, agg_expr, window_partition, "agg_bool"
@@ -121,7 +121,7 @@ def test_any_value(scalar_types_df: bpd.DataFrame, snapshot):
     snapshot.assert_match(sql, "out.sql")
 
     # Window tests
-    window = window_spec.WindowSpec(ordering=(ordering.ascending_over(col_name),))
+    window = window_spec.WindowSpec(ordering=(ordering.descending_over(col_name),))
     sql_window = _apply_unary_window_op(bf_df, agg_expr, window, "agg_int64")
     snapshot.assert_match(sql_window, "window_out.sql")
 
@@ -152,7 +152,7 @@ def test_count(scalar_types_df: bpd.DataFrame, snapshot):
     bf_df_str = scalar_types_df[[col_name, "string_col"]]
     window_partition = window_spec.WindowSpec(
         grouping_keys=(expression.deref("string_col"),),
-        ordering=(ordering.ascending_over(col_name),),
+        ordering=(ordering.descending_over(col_name),),
     )
     sql_window_partition = _apply_unary_window_op(
         bf_df_str, agg_expr, window_partition, "agg_int64"
@@ -166,7 +166,7 @@ def test_dense_rank(scalar_types_df: bpd.DataFrame, snapshot):
     agg_expr = agg_exprs.UnaryAggregation(
         agg_ops.DenseRankOp(), expression.deref(col_name)
     )
-    window = window_spec.WindowSpec(ordering=(ordering.ascending_over(col_name),))
+    window = window_spec.WindowSpec(ordering=(ordering.descending_over(col_name),))
     sql = _apply_unary_window_op(bf_df, agg_expr, window, "agg_int64")
 
     snapshot.assert_match(sql, "out.sql")
@@ -197,7 +197,7 @@ def test_diff(scalar_types_df: bpd.DataFrame, snapshot):
     # Test boolean
     bool_col = "bool_col"
     bf_df_bool = scalar_types_df[[bool_col]]
-    window = window_spec.WindowSpec(ordering=(ordering.ascending_over(bool_col),))
+    window = window_spec.WindowSpec(ordering=(ordering.descending_over(bool_col),))
     bool_op = agg_exprs.UnaryAggregation(
         agg_ops.DiffOp(periods=1), expression.deref(bool_col)
     )
@@ -213,7 +213,7 @@ def test_first(scalar_types_df: bpd.DataFrame, snapshot):
     col_name = "int64_col"
     bf_df = scalar_types_df[[col_name]]
     agg_expr = agg_exprs.UnaryAggregation(agg_ops.FirstOp(), expression.deref(col_name))
-    window = window_spec.WindowSpec(ordering=(ordering.ascending_over(col_name),))
+    window = window_spec.WindowSpec(ordering=(ordering.descending_over(col_name),))
     sql = _apply_unary_window_op(bf_df, agg_expr, window, "agg_int64")
 
     snapshot.assert_match(sql, "out.sql")
@@ -243,7 +243,7 @@ def test_last(scalar_types_df: bpd.DataFrame, snapshot):
     col_name = "int64_col"
     bf_df = scalar_types_df[[col_name]]
     agg_expr = agg_exprs.UnaryAggregation(agg_ops.LastOp(), expression.deref(col_name))
-    window = window_spec.WindowSpec(ordering=(ordering.ascending_over(col_name),))
+    window = window_spec.WindowSpec(ordering=(ordering.descending_over(col_name),))
     sql = _apply_unary_window_op(bf_df, agg_expr, window, "agg_int64")
 
     snapshot.assert_match(sql, "out.sql")
@@ -281,7 +281,7 @@ def test_max(scalar_types_df: bpd.DataFrame, snapshot):
     bf_df_str = scalar_types_df[[col_name, "string_col"]]
     window_partition = window_spec.WindowSpec(
         grouping_keys=(expression.deref("string_col"),),
-        ordering=(ordering.ascending_over(col_name),),
+        ordering=(ordering.descending_over(col_name),),
     )
     sql_window_partition = _apply_unary_window_op(
         bf_df_str, agg_expr, window_partition, "agg_int64"
@@ -319,7 +319,7 @@ def test_mean(scalar_types_df: bpd.DataFrame, snapshot):
     col_name = "int64_col"
     bf_df_int = scalar_types_df[[col_name]]
     agg_expr = agg_ops.MeanOp().as_expr(col_name)
-    window = window_spec.WindowSpec(ordering=(ordering.ascending_over(col_name),))
+    window = window_spec.WindowSpec(ordering=(ordering.descending_over(col_name),))
     sql_window = _apply_unary_window_op(bf_df_int, agg_expr, window, "agg_int64")
     snapshot.assert_match(sql_window, "window_out.sql")
 
@@ -362,7 +362,7 @@ def test_min(scalar_types_df: bpd.DataFrame, snapshot):
     bf_df_str = scalar_types_df[[col_name, "string_col"]]
     window_partition = window_spec.WindowSpec(
         grouping_keys=(expression.deref("string_col"),),
-        ordering=(ordering.ascending_over(col_name),),
+        ordering=(ordering.descending_over(col_name),),
     )
     sql_window_partition = _apply_unary_window_op(
         bf_df_str, agg_expr, window_partition, "agg_int64"
@@ -391,7 +391,9 @@ def test_rank(scalar_types_df: bpd.DataFrame, snapshot):
     bf_df = scalar_types_df[[col_name]]
     agg_expr = agg_exprs.UnaryAggregation(agg_ops.RankOp(), expression.deref(col_name))
 
-    window = window_spec.WindowSpec(ordering=(ordering.ascending_over(col_name),))
+    window = window_spec.WindowSpec(
+        ordering=(ordering.descending_over(col_name, nulls_last=False),)
+    )
     sql = _apply_unary_window_op(bf_df, agg_expr, window, "agg_int64")
 
     snapshot.assert_match(sql, "out.sql")
@@ -400,7 +402,9 @@ def test_rank(scalar_types_df: bpd.DataFrame, snapshot):
 def test_shift(scalar_types_df: bpd.DataFrame, snapshot):
     col_name = "int64_col"
     bf_df = scalar_types_df[[col_name]]
-    window = window_spec.WindowSpec(ordering=(ordering.ascending_over(col_name),))
+    window = window_spec.WindowSpec(
+        ordering=(ordering.ascending_over(col_name, nulls_last=False),)
+    )
 
     # Test lag
     lag_op = agg_exprs.UnaryAggregation(
@@ -440,7 +444,7 @@ def test_sum(scalar_types_df: bpd.DataFrame, snapshot):
     col_name = "int64_col"
     bf_df_int = scalar_types_df[[col_name]]
     agg_expr = agg_ops.SumOp().as_expr(col_name)
-    window = window_spec.WindowSpec(ordering=(ordering.ascending_over(col_name),))
+    window = window_spec.WindowSpec(ordering=(ordering.descending_over(col_name),))
     sql_window = _apply_unary_window_op(bf_df_int, agg_expr, window, "agg_int64")
     snapshot.assert_match(sql_window, "window_out.sql")