Skip to content

Commit 778ab34

Browse files
committed
fix mypy and tests
1 parent 5c487d7 commit 778ab34

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

bigframes/core/reshape/merge.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
from __future__ import annotations
2020

21-
from typing import Literal, Optional, Sequence, Union
21+
from typing import Literal, Sequence
2222

2323
import bigframes_vendored.pandas.core.reshape.merge as vendored_pandas_merge
2424

@@ -36,10 +36,10 @@ def merge(
3636
"right",
3737
"cross",
3838
] = "inner",
39-
on: Optional[str] = None,
39+
on: blocks.Label | Sequence[blocks.Label] | None = None,
4040
*,
41-
left_on: Optional[str] = None,
42-
right_on: Optional[str] = None,
41+
left_on: blocks.Label | Sequence[blocks.Label] | None = None,
42+
right_on: blocks.Label | Sequence[blocks.Label] | None = None,
4343
sort: bool = False,
4444
suffixes: tuple[str, str] = ("_x", "_y"),
4545
) -> dataframe.DataFrame:
@@ -60,7 +60,7 @@ def merge(
6060
return dataframe.DataFrame(result_block)
6161

6262
left_on, right_on = _validate_left_right_on(
63-
right, on, left_on=left_on, right_on=right_on
63+
left, right, on, left_on=left_on, right_on=right_on
6464
)
6565

6666
if utils.is_list_like(left_on):
@@ -123,10 +123,10 @@ def _validate_operand(
123123
def _validate_left_right_on(
124124
left: dataframe.DataFrame,
125125
right: dataframe.DataFrame,
126-
on: Union[blocks.Label, Sequence[blocks.Label], None] = None,
126+
on: blocks.Label | Sequence[blocks.Label] | None = None,
127127
*,
128-
left_on: Union[blocks.Label, Sequence[blocks.Label], None] = None,
129-
right_on: Union[blocks.Label, Sequence[blocks.Label], None] = None,
128+
left_on: blocks.Label | Sequence[blocks.Label] | None = None,
129+
right_on: blocks.Label | Sequence[blocks.Label] | None = None,
130130
):
131131
if on is not None:
132132
if left_on is not None or right_on is not None:

0 commit comments

Comments
 (0)