Skip to content

Commit 79895ad

Browse files
committed
remove test_engines_astype_struct_to_json for internal discussions 444196993
1 parent 9e928f9 commit 79895ad

File tree

2 files changed

+0
-38
lines changed

2 files changed

+0
-38
lines changed

tests/system/small/engines/conftest.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -73,13 +73,6 @@ def scalars_array_value(
7373
return ArrayValue.from_managed(managed_data_source, fake_session)
7474

7575

76-
@pytest.fixture(scope="module")
77-
def nested_array_value(
78-
nested_data_source: local_data.ManagedArrowTable, fake_session: bigframes.Session
79-
):
80-
return ArrayValue.from_managed(nested_data_source, fake_session)
81-
82-
8376
@pytest.fixture(scope="module")
8477
def zero_row_source() -> local_data.ManagedArrowTable:
8578
return local_data.ManagedArrowTable.from_pandas(pd.DataFrame({"a": [], "b": []}))

tests/system/small/engines/test_generic_ops.py

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414

1515
import re
1616

17-
import pandas as pd
18-
import pyarrow as pa
1917
import pytest
2018

2119
from bigframes.core import array_value, expression
@@ -300,35 +298,6 @@ def test_engines_astype_to_json(scalars_array_value: array_value.ArrayValue, eng
300298
assert_equivalence_execution(arr.node, REFERENCE_ENGINE, engine)
301299

302300

303-
@pytest.mark.parametrize("engine", ["polars", "bq"], indirect=True)
304-
def test_engines_astype_struct_to_json(
305-
nested_array_value: array_value.ArrayValue, engine
306-
):
307-
json_data = [
308-
{"version": 1, "project": "pandas"},
309-
{"version": 2, "project": "numpy"},
310-
]
311-
exprs = [
312-
# ops.AsTypeOp(to_type=bigframes.dtypes.JSON_DTYPE).as_expr(
313-
# expression.deref("label")
314-
# ),
315-
# ops.AsTypeOp(to_type=bigframes.dtypes.JSON_DTYPE).as_expr(
316-
# expression.deref("address")
317-
# ),
318-
ops.AsTypeOp(to_type=bigframes.dtypes.JSON_DTYPE).as_expr(
319-
expression.const(
320-
json_data,
321-
pd.ArrowDtype(
322-
pa.struct([("version", pa.int64()), ("project", pa.string())])
323-
),
324-
)
325-
),
326-
]
327-
arr, _ = nested_array_value.compute_values(exprs)
328-
329-
assert_equivalence_execution(arr.node, REFERENCE_ENGINE, engine)
330-
331-
332301
@pytest.mark.parametrize("engine", ["polars", "bq"], indirect=True)
333302
def test_engines_astype_timedelta(scalars_array_value: array_value.ArrayValue, engine):
334303
arr = apply_op(

0 commit comments

Comments
 (0)