display page 1 of many

Author: shuoweil

bigframes/display/table_widget.js

@@ -89,16 +89,14 @@ function render({ model, el }) {
 		if (rowCount === null) {
 			// Unknown total rows
 			rowCountLabel.textContent = "Total rows unknown";
-			paginationLabel.textContent = `Page ${(currentPage + 1).toLocaleString()}`;
+			paginationLabel.textContent = `Page ${(currentPage + 1).toLocaleString()} of many`;
 			prevPage.disabled = currentPage === 0;
 			nextPage.disabled = false; // Allow navigation until we hit the end
 		} else {
 			// Known total rows
 			const totalPages = Math.ceil(rowCount / pageSize);
 			rowCountLabel.textContent = `${rowCount.toLocaleString()} total rows`;
-			paginationLabel.textContent = `Page ${(
-				currentPage + 1
-			).toLocaleString()} of ${(totalPages || 1).toLocaleString()}`;
+			paginationLabel.textContent = `Page ${(currentPage + 1).toLocaleString()} of ${rowCount.toLocaleString()}`;
 			prevPage.disabled = currentPage === 0;
 			nextPage.disabled = currentPage >= totalPages - 1;
 		}

notebooks/dataframes/anywidget_mode.ipynb

@@ -35,16 +35,7 @@
    "execution_count": 2,
    "id": "ca22f059",
    "metadata": {},
-   "outputs": [
-    {
-     "name": "stderr",
-     "output_type": "stream",
-     "text": [
-      "/usr/local/google/home/shuowei/src/python-bigquery-dataframes/venv/lib/python3.10/site-packages/google/api_core/_python_version_support.py:266: FutureWarning: You are using a Python version (3.10.15) which Google will stop supporting in new releases of google.api_core once it reaches its end of life (2026-10-04). Please upgrade to the latest Python version, or at least Python 3.11, to continue receiving updates for google.api_core past that date.\n",
-      "  warnings.warn(message, FutureWarning)\n"
-     ]
-    }
-   ],
+   "outputs": [],
    "source": [
     "import bigframes.pandas as bpd"
    ]
@@ -151,7 +142,7 @@
     {
      "data": {
       "application/vnd.jupyter.widget-view+json": {
-       "model_id": "47795eaa10f149aeb99574232c0936eb",
+       "model_id": "710b4e9c06df4faf82011dd676e9d9a5",
        "version_major": 2,
        "version_minor": 1
       },
@@ -214,7 +205,7 @@
     {
      "data": {
       "application/vnd.jupyter.widget-view+json": {
-       "model_id": "8354ce0f82d3495a9b630dfc362f73ee",
+       "model_id": "62661c02a1a742d79e53dcb047343e86",
        "version_major": 2,
        "version_minor": 1
       },
@@ -293,27 +284,8 @@
     {
      "data": {
       "text/html": [
-       "\n",
-       "    Query started with request ID bigframes-dev:US.c45952fb-01b4-409c-9da4-f7c5bfc0d47d.<details><summary>SQL</summary><pre>SELECT\n",
-       "`state` AS `state`,\n",
-       "`gender` AS `gender`,\n",
-       "`year` AS `year`,\n",
-       "`name` AS `name`,\n",
-       "`number` AS `number`\n",
-       "FROM\n",
-       "(SELECT\n",
-       "  *\n",
-       "FROM (\n",
-       "  SELECT\n",
-       "    `state`,\n",
-       "    `gender`,\n",
-       "    `year`,\n",
-       "    `name`,\n",
-       "    `number`\n",
-       "  FROM `bigquery-public-data.usa_names.usa_1910_2013` FOR SYSTEM_TIME AS OF TIMESTAMP(&#x27;2025-10-30T21:48:48.979701+00:00&#x27;)\n",
-       ") AS `t0`)\n",
-       "ORDER BY `name` ASC NULLS LAST ,`year` ASC NULLS LAST ,`state` ASC NULLS LAST\n",
-       "LIMIT 5</pre></details>\n",
+       "✅ Completed. \n",
+       "    Query processed 171.4 MB in a moment of slot time.\n",
        "    "
       ],
       "text/plain": [
@@ -333,7 +305,7 @@
     {
      "data": {
       "application/vnd.jupyter.widget-view+json": {
-       "model_id": "59461286a17d4a42b6be6d9d9c7bf7e3",
+       "model_id": "b92000a35d0c4b8a9a8aaef4784e94dd",
        "version_major": 2,
        "version_minor": 1
       },
@@ -360,7 +332,7 @@
    "metadata": {},
    "source": [
     "### Handling of Invalid Row Count\n",
-    "In cases where the total number of rows cannot be determined, `row_count` will be `None`. The widget will display 'Total rows unknown', and you can navigate forward until you reach the end of the available data. If you navigate beyond the last page, the widget will automatically return to the last valid page."
+    "In cases where the total number of rows cannot be determined, `row_count` will be `None`. The widget will display 'Page X of many', and you can navigate forward until you reach the end of the available data. If you navigate beyond the last page, the widget will automatically return to the last valid page."
    ]
   },
   {
@@ -382,7 +354,7 @@
      "data": {
       "text/html": [
        "✅ Completed. \n",
-       "    Query processed 85.9 kB in 14 seconds of slot time.\n",
+       "    Query processed 85.9 kB in 13 seconds of slot time.\n",
        "    "
       ],
       "text/plain": [
@@ -396,7 +368,7 @@
      "name": "stderr",
      "output_type": "stream",
      "text": [
-      "/usr/local/google/home/shuowei/src/python-bigquery-dataframes/bigframes/dtypes.py:969: JSONDtypeWarning: JSON columns will be represented as pandas.ArrowDtype(pyarrow.json_())\n",
+      "/usr/local/google/home/shuowei/src/python-bigquery-dataframes/bigframes/dtypes.py:987: JSONDtypeWarning: JSON columns will be represented as pandas.ArrowDtype(pyarrow.json_())\n",
       "instead of using `db_dtypes` in the future when available in pandas\n",
       "(https://github.com/pandas-dev/pandas/issues/60958) and pyarrow.\n",
       "  warnings.warn(msg, bigframes.exceptions.JSONDtypeWarning)\n"
@@ -417,7 +389,7 @@
     {
      "data": {
       "application/vnd.jupyter.widget-view+json": {
-       "model_id": "d1794b42579542a8980bd158e521bd3e",
+       "model_id": "2620318ca07e405fa7ce950a2d931e6a",
        "version_major": 2,
        "version_minor": 1
       },

tests/system/small/test_anywidget.py

@@ -591,12 +591,12 @@ def test_widget_with_unknown_row_count_should_auto_navigate_to_last_page(
         assert "row_0" not in html  # First row should not be visible
 
 
-def test_widget_with_unknown_row_count_should_display_correct_ui_text(
+def test_widget_with_unknown_row_count_should_set_none_state_for_frontend(
     session: bf.Session,
 ):
     """
-    Given a widget with unknown row count, the JavaScript frontend should
-    display appropriate text indicating the total is unknown.
+    Given a widget with unknown row count, its `row_count` traitlet should be
+    `None`, which signals the frontend to display 'Page X of many'.
     """
     from bigframes.display import TableWidget
 
@@ -621,6 +621,10 @@ def test_widget_with_unknown_row_count_should_display_correct_ui_text(
         assert widget.page == 0
         assert widget.page_size == 2
 
+        # Force data loading by accessing table_html. This also ensures that
+        # rendering does not raise an exception.
+        _ = widget.table_html
+
 
 def test_widget_with_unknown_row_count_should_allow_forward_navigation(
     session: bf.Session,
@@ -688,5 +692,9 @@ def test_widget_with_unknown_row_count_empty_dataframe(
 
 
 # TODO(shuowei): Add tests for custom index and multiindex
+
+
 # This may not be necessary for the SQL Cell use case but should be
+
+
 # considered for completeness.