Skip to content

Commit 9e40021

Browse files
committed
address comments
1 parent b771319 commit 9e40021

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

tests/unit/core/compile/sqlglot/aggregations/test_op_registration.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def test_func(op: agg_ops.SizeOp, input: sge.Expression) -> sge.Expression:
3232
assert reg[agg_ops.SizeOp.name](op, input) == test_func(op, input)
3333

3434

35-
def test_register_function_first_argument_is_not_scalar_op_raise_error():
35+
def test_register_function_first_argument_is_not_agg_op_raise_error():
3636
reg = op_registration.OpRegistration()
3737

3838
@reg.register(agg_ops.SizeOp)

tests/unit/core/compile/sqlglot/aggregations/test_unary_compiler.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,12 @@ def _apply_unary_op(obj: bpd.DataFrame, op: agg_ops.UnaryWindowOp, arg: str) ->
4040
def test_size(scalar_types_df: bpd.DataFrame, snapshot):
4141
bf_df = scalar_types_df[["string_col"]]
4242
sql = _apply_unary_op(bf_df, agg_ops.SizeUnaryOp(), "string_col")
43+
4344
snapshot.assert_match(sql, "out.sql")
4445

4546

4647
def test_sum(scalar_types_df: bpd.DataFrame, snapshot):
4748
bf_df = scalar_types_df[["int64_col"]]
4849
sql = _apply_unary_op(bf_df, agg_ops.SumOp(), "int64_col")
50+
4951
snapshot.assert_match(sql, "out.sql")

0 commit comments

Comments
 (0)