fix

Author: jialuoo

bigframes/blob/_functions.py

@@ -31,6 +31,8 @@
     bytes: "BYTES",
     bool: "BOOL",
 }
+# UDFs older than this many days are considered stale and will be deleted
+# from the anonymous dataset before creating a new UDF.
 _UDF_CLEANUP_THRESHOLD_DAYS = 3
 
 
@@ -80,13 +82,13 @@ def _cleanup_old_udfs(self):
         """Clean up old UDFs in the anonymous dataset."""
         dataset = self._session._anon_dataset_manager.dataset
         routines = list(self._session.bqclient.list_routines(dataset))
-        seven_days_ago = datetime.datetime.now(
+        cleanup_cutoff_time = datetime.datetime.now(
             datetime.timezone.utc
         ) - datetime.timedelta(days=_UDF_CLEANUP_THRESHOLD_DAYS)
 
         for routine in routines:
             if (
-                routine.created < seven_days_ago
+                routine.created < cleanup_cutoff_time
                 and routine._properties["routineType"] == "SCALAR_FUNCTION"
             ):
                 try:
@@ -100,15 +102,14 @@ def _create_udf(self):
             self._session._anon_dataset_manager.generate_unique_resource_id()
         )
 
-        # Try to clean up the old Python UDFs in the anonymous dataset. Failure
-        # to clean up is logged as a warning but does not halt execution.
         try:
             # Before creating a new UDF, attempt to clean up any uncollected,
             # old Python UDFs residing in the anonymous dataset. These UDFs
             # accumulate over time and can eventually exceed resource limits.
             # See more from b/450913424.
             self._cleanup_old_udfs()
         except Exception as e:
+            # Log a warning on the failure, do not interrupt the workflow.
             msg = bfe.format_message(
                 f"Failed to clean up the old Python UDFs before creating {udf_name}: {e}"
             )