Skip to content

Commit df64564

Browse files
committed
remove unnecessary tests
1 parent 54df50a commit df64564

File tree

5 files changed

+5
-38
lines changed

5 files changed

+5
-38
lines changed

tests/benchmark/read_gbq_colab/filter_output.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,4 +56,4 @@ def filter_output(
5656
project_id=config.project_id,
5757
dataset_id=config.dataset_id,
5858
table_id=config.table_id,
59-
)
59+
)

tests/benchmark/read_gbq_colab/first_page.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,4 @@ def first_page(*, project_id, dataset_id, table_id):
4343
project_id=config.project_id,
4444
dataset_id=config.dataset_id,
4545
table_id=config.table_id,
46-
)
46+
)

tests/benchmark/read_gbq_colab/last_page.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,4 @@ def last_page(*, project_id, dataset_id, table_id):
4343
project_id=config.project_id,
4444
dataset_id=config.dataset_id,
4545
table_id=config.table_id,
46-
)
46+
)

tests/benchmark/read_gbq_colab/sort_output.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,7 @@ def sort_output(*, project_id, dataset_id, table_id):
3737

3838
df_sorted = df.sort_values(sort_column)
3939
batches_sorted = df_sorted.to_pandas_batches(page_size=PAGE_SIZE)
40-
assert (
41-
batches_sorted.total_rows is not None
42-
and batches_sorted.total_rows >= 0
43-
)
40+
assert batches_sorted.total_rows is not None and batches_sorted.total_rows >= 0
4441
next(iter(batches_sorted))
4542

4643

@@ -50,10 +47,9 @@ def sort_output(*, project_id, dataset_id, table_id):
5047

5148
utils.get_execution_time(
5249
sort_output,
53-
.
5450
current_path,
5551
config.benchmark_suffix,
5652
project_id=config.project_id,
5753
dataset_id=config.dataset_id,
5854
table_id=config.table_id,
59-
)
55+
)

tests/system/small/test_anywidget.py

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import pytest
1818

1919
import bigframes as bf
20-
import bigframes.pandas as bpd
2120

2221
pytest.importorskip("anywidget")
2322

@@ -532,34 +531,6 @@ def test_widget_row_count_reflects_actual_data_available(
532531
assert widget.page_size == 2 # Respects the display option
533532

534533

535-
def test_repr_html_raises_when_row_count_is_none(monkeypatch):
536-
df = bpd.DataFrame({"col1": [1, 2, 3]})
537-
538-
def mock_retrieve_repr_request_results(*args, **kwargs):
539-
return df.to_pandas(), None, None
540-
541-
monkeypatch.setattr(
542-
df._block, "retrieve_repr_request_results", mock_retrieve_repr_request_results
543-
)
544-
545-
with pytest.raises(NotImplementedError):
546-
df._repr_html_()
547-
548-
549-
def test_repr_raises_when_row_count_is_none(monkeypatch):
550-
df = bpd.DataFrame({"col1": [1, 2, 3]})
551-
552-
def mock_retrieve_repr_request_results(*args, **kwargs):
553-
return df.to_pandas(), None, None
554-
555-
monkeypatch.setattr(
556-
df._block, "retrieve_repr_request_results", mock_retrieve_repr_request_results
557-
)
558-
559-
with pytest.raises(NotImplementedError):
560-
df.__repr__()
561-
562-
563534
# TODO(shuowei): Add tests for custom index and multiindex
564535
# This may not be necessary for the SQL Cell use case but should be
565536
# considered for completeness.

0 commit comments

Comments
 (0)