Skip to content

Commit e654974

Browse files
committed
bug id fix
1 parent 3b42978 commit e654974

File tree

3 files changed

+8
-15
lines changed

3 files changed

+8
-15
lines changed

bigframes/display/anywidget.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ def _set_table_html(self) -> None:
297297
page_data = cached_data.iloc[start:end].copy()
298298

299299
# Handle index display
300-
# TODO(b/332316283): Add tests for custom multiindex
300+
# TODO(b/438181139): Add tests for custom multiindex
301301
if self._dataframe._block.has_index:
302302
index_name = page_data.index.name
303303
page_data.insert(

noxfile.py

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,8 @@
6666

6767
UNIT_TEST_PYTHON_VERSIONS = ["3.9", "3.10", "3.11", "3.12", "3.13"]
6868
UNIT_TEST_STANDARD_DEPENDENCIES = [
69+
"mock",
70+
"asyncmock",
6971
PYTEST_VERSION,
7072
"pytest-asyncio",
7173
"pytest-cov",
@@ -90,6 +92,7 @@
9092
SYSTEM_TEST_PYTHON_VERSIONS = ["3.9", "3.10", "3.11", "3.12", "3.13"]
9193
SYSTEM_TEST_STANDARD_DEPENDENCIES = [
9294
"jinja2",
95+
"mock",
9396
"openpyxl",
9497
PYTEST_VERSION,
9598
"pytest-cov",
@@ -204,10 +207,7 @@ def lint_setup_py(session):
204207

205208
def install_unittest_dependencies(session, install_test_extra, *constraints):
206209
standard_deps = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_DEPENDENCIES
207-
session.install("setuptools", "wheel")
208-
session.install(
209-
"--extra-index-url", "https://pypi.org/simple/", *standard_deps, *constraints
210-
)
210+
session.install(*standard_deps, *constraints)
211211

212212
if UNIT_TEST_LOCAL_DEPENDENCIES:
213213
session.install(*UNIT_TEST_LOCAL_DEPENDENCIES, *constraints)
@@ -224,7 +224,6 @@ def install_unittest_dependencies(session, install_test_extra, *constraints):
224224

225225
def run_unit(session, install_test_extra):
226226
"""Run the unit test suite."""
227-
session.env["PIP_EXTRA_INDEX_URL"] = "https://pypi.org/simple/"
228227
constraints_path = str(
229228
CURRENT_DIRECTORY / "testing" / f"constraints-{session.python}.txt"
230229
)
@@ -314,13 +313,7 @@ def install_systemtest_dependencies(session, install_test_extra, *constraints):
314313
# See https://github.com/grpc/grpc/pull/30642
315314
session.install("--pre", "grpcio!=1.49.0rc1")
316315

317-
session.install("setuptools", "wheel")
318-
session.install(
319-
"--extra-index-url",
320-
"https://pypi.org/simple/",
321-
*SYSTEM_TEST_STANDARD_DEPENDENCIES,
322-
*constraints,
323-
)
316+
session.install(*SYSTEM_TEST_STANDARD_DEPENDENCIES, *constraints)
324317

325318
if SYSTEM_TEST_EXTERNAL_DEPENDENCIES:
326319
session.install(*SYSTEM_TEST_EXTERNAL_DEPENDENCIES, *constraints)
@@ -356,7 +349,7 @@ def run_system(
356349
timeout_seconds=900,
357350
num_workers=20,
358351
):
359-
session.env["PIP_EXTRA_INDEX_URL"] = "https://pypi.org/simple/"
352+
"""Run the system test suite."""
360353
constraints_path = str(
361354
CURRENT_DIRECTORY / "testing" / f"constraints-{session.python}.txt"
362355
)

tests/system/small/test_anywidget.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1132,6 +1132,6 @@ def test_widget_with_custom_index_matches_pandas_output(
11321132
assert "row_4" not in html # Verify it respects max_rows
11331133

11341134

1135-
# TODO(b/332316283): Add tests for custom multiindex
1135+
# TODO(b/438181139): Add tests for custom multiindex
11361136
# This may not be necessary for the SQL Cell use case but should be
11371137
# considered for completeness.

0 commit comments

Comments
 (0)