chore: remove try catch

Author: shuoweil

bigframes/display/table_widget.css

@@ -14,7 +14,8 @@
  * limitations under the License.
  */
 
-.bigframes-widget {
+/* Increase specificity to override framework styles without !important */
+.bigframes-widget.bigframes-widget {
 	/* Default Light Mode Variables */
 	--bf-bg: white;
 	--bf-border-color: #ccc;
@@ -27,15 +28,15 @@
 	--bf-row-even-bg: #f5f5f5;
 	--bf-row-odd-bg: white;
 
-	background-color: var(--bf-bg) !important;
+	background-color: var(--bf-bg);
 	box-sizing: border-box;
-	color: var(--bf-fg) !important;
+	color: var(--bf-fg);
 	display: flex;
 	flex-direction: column;
 	font-family:
 		"-apple-system", "BlinkMacSystemFont", "Segoe UI", "Roboto", sans-serif;
-	margin: 0 !important;
-	padding: 0 !important;
+	margin: 0;
+	padding: 0;
 }
 
 .bigframes-widget * {
@@ -44,7 +45,7 @@
 
 /* Dark Mode Overrides via Media Query */
 @media (prefers-color-scheme: dark) {
-	.bigframes-widget {
+	.bigframes-widget.bigframes-widget {
 		--bf-bg: var(--vscode-editor-background, #202124);
 		--bf-border-color: #444;
 		--bf-error-bg: #511;
@@ -123,29 +124,28 @@
 	margin-right: 8px;
 }
 
-.bigframes-widget table,
+.bigframes-widget table.bigframes-widget-table,
 .bigframes-widget table.dataframe {
-	background-color: var(--bf-bg) !important;
-	/* Explicitly override border="1" defaults */
-	border: 1px solid var(--bf-border-color) !important;
-	border-collapse: collapse !important;
-	border-spacing: 0 !important;
-	box-shadow: none !important;
-	color: var(--bf-fg) !important;
-	margin: 0 !important;
-	outline: none !important;
+	background-color: var(--bf-bg);
+	border: 1px solid var(--bf-border-color);
+	border-collapse: collapse;
+	border-spacing: 0;
+	box-shadow: none;
+	color: var(--bf-fg);
+	margin: 0;
+	outline: none;
 	text-align: left;
-	width: auto !important; /* Fix stretching */
+	width: auto; /* Fix stretching */
 }
 
 .bigframes-widget tr {
-	border: none !important;
+	border: none;
 }
 
 .bigframes-widget th {
-	background-color: var(--bf-header-bg) !important;
-	border: 1px solid var(--bf-border-color) !important;
-	color: var(--bf-fg) !important;
+	background-color: var(--bf-header-bg);
+	border: 1px solid var(--bf-border-color);
+	color: var(--bf-fg);
 	padding: 0;
 	position: sticky;
 	text-align: left;
@@ -154,19 +154,19 @@
 }
 
 .bigframes-widget td {
-	border: 1px solid var(--bf-border-color) !important;
-	color: var(--bf-fg) !important;
+	border: 1px solid var(--bf-border-color);
+	color: var(--bf-fg);
 	padding: 0.5em;
 }
 
 .bigframes-widget table tbody tr:nth-child(odd),
 .bigframes-widget table tbody tr:nth-child(odd) td {
-	background-color: var(--bf-row-odd-bg) !important;
+	background-color: var(--bf-row-odd-bg);
 }
 
 .bigframes-widget table tbody tr:nth-child(even),
 .bigframes-widget table tbody tr:nth-child(even) td {
-	background-color: var(--bf-row-even-bg) !important;
+	background-color: var(--bf-row-even-bg);
 }
 
 .bigframes-widget .bf-header-content {
@@ -229,5 +229,5 @@
 }
 
 .bigframes-widget .debug-info {
-	border-top: 1px solid var(--bf-border-color) !important;
+	border-top: 1px solid var(--bf-border-color);
 }

bigframes/display/table_widget.js

@@ -62,28 +62,20 @@ function render({ model, el }) {
 	function setContainerStyles(isDark) {
 		const body = document.body;
 		if (isDark) {
-			// Clear ancestor backgrounds to reveal the dark body background
-			try {
-				let parent = el.parentElement;
-				while (parent && parent !== body) {
-					parent.style.setProperty(
-						"background-color",
-						"transparent",
-						"important",
-					);
-					parent.style.setProperty("padding", "0", "important");
-					parent = parent.parentElement;
-				}
-			} catch (e) {}
+			// Clear background of ancestors to remove "white frame" from containers.
+			let parent = el.parentElement;
+			while (parent && parent !== document.body) {
+				parent.style.setProperty("background-color", "transparent");
+				parent.style.setProperty("padding", "0");
+				parent = parent.parentElement;
+			}
 
-			// Force body and html to dark background to cover full iframe area
 			if (body) {
-				body.style.setProperty("background-color", "#202124", "important");
-				body.style.setProperty("margin", "0", "important");
+				body.style.setProperty("background-color", "#202124");
+				body.style.setProperty("margin", "0");
 				document.documentElement.style.setProperty(
 					"background-color",
 					"#202124",
-					"important",
 				);
 			}
 		} else {