Skip to content

Commit fe072f3

Browse files
committed
fix mypy
1 parent 1cf1b98 commit fe072f3

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

bigframes/core/compile/sqlglot/aggregations/op_registration.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def arg_checker(*args, **kwargs):
4444
key = op if isinstance(op, type) else type(op)
4545
if key in self._registered_ops:
4646
raise ValueError(f"{key} is already registered")
47-
self._registered_ops[key] = item
47+
self._registered_ops[str(key)] = item
4848
return arg_checker
4949

5050
return decorator
@@ -57,5 +57,5 @@ def __getitem__(self, op: str | agg_ops.WindowOp) -> CompilationFunc:
5757
key = typing.cast(str, op.name)
5858
if key in self._registered_ops:
5959
return self._registered_ops[key]
60-
return self._registered_ops[type(op)]
60+
return self._registered_ops[str(type(op))]
6161
return self._registered_ops[op]

bigframes/core/compile/sqlglot/aggregations/unary_compiler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ def _(
148148
) -> sge.Expression:
149149
# TODO: Support interpolation argument
150150
# TODO: Support percentile_disc
151-
result = sge.func("PERCENTILE_CONT", column.expr, sge.convert(op.q))
151+
result: sge.Expression = sge.func("PERCENTILE_CONT", column.expr, sge.convert(op.q))
152152
if window is None:
153153
# PERCENTILE_CONT is a navigation function, not an aggregate function, so it always needs an OVER clause.
154154
result = sge.Window(this=result)

bigframes/operations/aggregations.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,10 +223,13 @@ def output_type(self, *input_types: dtypes.ExpressionType) -> dtypes.ExpressionT
223223

224224
@dataclasses.dataclass(frozen=True)
225225
class QuantileOp(UnaryAggregateOp):
226-
name: typing.ClassVar[str] = "quantile"
227226
q: float
228227
should_floor_result: bool = False
229228

229+
@property
230+
def name(self):
231+
return f"{int(self.q * 100)}%"
232+
230233
@property
231234
def order_independent(self) -> bool:
232235
return True

0 commit comments

Comments
 (0)