test: Unskipped wait_for_consistency system tests in emulator (#1186)

* test: Unskipped wait_for_consistency system tests in emulator

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Added sync surface

* Actual sync surface

* Used pytest.mark.skipif

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Author: gkevinzheng

tests/system/admin_overlay/test_system_async.py

@@ -143,20 +143,27 @@ async def create_instance(
             default_storage_type=storage_type,
         )
 
-    create_instance_request = admin_v2.CreateInstanceRequest(
-        parent=instance_admin_client.common_project_path(project_id),
-        instance_id=instance_id,
-        instance=admin_v2.Instance(
-            display_name=instance_id[
-                :30
-            ],  # truncate to 30 characters because of character limit
-        ),
-        clusters=clusters,
-    )
-    operation = await instance_admin_client.create_instance(create_instance_request)
-    instance = await operation.result()
+    # Instance and cluster creation are currently unsupported in the Bigtable emulator
+    if os.getenv(BIGTABLE_EMULATOR):
+        # All we need for system tests so far is the instance name.
+        instance = admin_v2.Instance(
+            name=instance_admin_client.instance_path(project_id, instance_id),
+        )
+    else:
+        create_instance_request = admin_v2.CreateInstanceRequest(
+            parent=instance_admin_client.common_project_path(project_id),
+            instance_id=instance_id,
+            instance=admin_v2.Instance(
+                display_name=instance_id[
+                    :30
+                ],  # truncate to 30 characters because of character limit
+            ),
+            clusters=clusters,
+        )
+        operation = await instance_admin_client.create_instance(create_instance_request)
+        instance = await operation.result()
 
-    instances_to_delete.append(instance)
+        instances_to_delete.append(instance)
 
     # Create a table within the instance
     create_table_request = admin_v2.CreateTableRequest(
@@ -272,6 +279,10 @@ async def assert_table_cell_value_equal_to(
     }
 )
 @CrossSync.pytest
+@pytest.mark.skipif(
+    os.getenv(BIGTABLE_EMULATOR),
+    reason="Backups are not supported in the Bigtable emulator",
+)
 @pytest.mark.parametrize(
     "second_instance_storage_type,expect_optimize_operation",
     [

tests/system/admin_overlay/test_system_autogen.py

@@ -113,15 +113,20 @@ def create_instance(
             location=instance_admin_client.common_location_path(project_id, location),
             default_storage_type=storage_type,
         )
-    create_instance_request = admin_v2.CreateInstanceRequest(
-        parent=instance_admin_client.common_project_path(project_id),
-        instance_id=instance_id,
-        instance=admin_v2.Instance(display_name=instance_id[:30]),
-        clusters=clusters,
-    )
-    operation = instance_admin_client.create_instance(create_instance_request)
-    instance = operation.result()
-    instances_to_delete.append(instance)
+    if os.getenv(BIGTABLE_EMULATOR):
+        instance = admin_v2.Instance(
+            name=instance_admin_client.instance_path(project_id, instance_id)
+        )
+    else:
+        create_instance_request = admin_v2.CreateInstanceRequest(
+            parent=instance_admin_client.common_project_path(project_id),
+            instance_id=instance_id,
+            instance=admin_v2.Instance(display_name=instance_id[:30]),
+            clusters=clusters,
+        )
+        operation = instance_admin_client.create_instance(create_instance_request)
+        instance = operation.result()
+        instances_to_delete.append(instance)
     create_table_request = admin_v2.CreateTableRequest(
         parent=instance_admin_client.instance_path(project_id, instance_id),
         table_id=TEST_TABLE_NAME,
@@ -201,6 +206,10 @@ def assert_table_cell_value_equal_to(
         assert latest_cell.value.decode("utf-8") == value
 
 
+@pytest.mark.skipif(
+    os.getenv(BIGTABLE_EMULATOR),
+    reason="Backups are not supported in the Bigtable emulator",
+)
 @pytest.mark.parametrize(
     "second_instance_storage_type,expect_optimize_operation",
     [(admin_v2.StorageType.HDD, False), (admin_v2.StorageType.SSD, True)],
@@ -215,15 +224,15 @@ def test_optimize_restored_table(
     second_instance_storage_type,
     expect_optimize_operation,
 ):
-    instance_with_backup, table_to_backup = create_instance(
+    (instance_with_backup, table_to_backup) = create_instance(
         instance_admin_client,
         table_admin_client,
         data_client,
         admin_overlay_project_id,
         instances_to_delete,
         admin_v2.StorageType.HDD,
     )
-    instance_to_restore, _ = create_instance(
+    (instance_to_restore, _) = create_instance(
         instance_admin_client,
         table_admin_client,
         data_client,
@@ -273,7 +282,7 @@ def test_wait_for_consistency(
     instances_to_delete,
     admin_overlay_project_id,
 ):
-    instance, table = create_instance(
+    (instance, table) = create_instance(
         instance_admin_client,
         table_admin_client,
         data_client,