-
Notifications
You must be signed in to change notification settings - Fork 61
Open
Labels
api: bigtableIssues related to the googleapis/python-bigtable API.Issues related to the googleapis/python-bigtable API.priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
Description
go/bigtable_legacy_deprecation details a few places where library internals are exposed publicly. For the most part, these are internal varaibles that aren't marked as internal. They shouldn't be widely used, but are techincailly part of the public API surface.
We should identify these, and either:
- update the docstrings to make it clear that usage is not supported
- mark variables as private using underscore notation
- raise exceptions in places they are used
We should also make note of these changes in the UPGRADING.md file
I'd suggest doing a PR trying to resolve of this before starting the majority of the shim work.
We should probably open two PRs for this:
- a PR to main marking these as deprecated now, so it's not a big surprise when they are removed later
- a PR into the
v3branch, removing them for the major release
Examples:
- PartialRowData.resonse_iterator
- PartialRowsData's construtor
- Retry object on_error callbacks
- Mutations Batcher callbacks
- maybe this can be partially supported?
- RowFilter.to_pb
Metadata
Metadata
Assignees
Labels
api: bigtableIssues related to the googleapis/python-bigtable API.Issues related to the googleapis/python-bigtable API.priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.