Skip to content

Find and deprecate leaky abstractions #1159

@daniel-sanche

Description

@daniel-sanche

go/bigtable_legacy_deprecation details a few places where library internals are exposed publicly. For the most part, these are internal varaibles that aren't marked as internal. They shouldn't be widely used, but are techincailly part of the public API surface.

We should identify these, and either:

  1. update the docstrings to make it clear that usage is not supported
  2. mark variables as private using underscore notation
  3. raise exceptions in places they are used

We should also make note of these changes in the UPGRADING.md file

I'd suggest doing a PR trying to resolve of this before starting the majority of the shim work.

We should probably open two PRs for this:

  1. a PR to main marking these as deprecated now, so it's not a big surprise when they are removed later
  2. a PR into the v3 branch, removing them for the major release

Examples:

Metadata

Metadata

Assignees

Labels

api: bigtableIssues related to the googleapis/python-bigtable API.priority: p3Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions