Skip to content

Commit dcfaeff

Browse files
committed
try reverting callback changes
1 parent 9fb4a1a commit dcfaeff

File tree

1 file changed

+2
-16
lines changed

1 file changed

+2
-16
lines changed

google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -151,14 +151,6 @@ def _wrap_callback_errors(
151151
callback: The user callback.
152152
message: The Pub/Sub message.
153153
"""
154-
_CALLBACK_DELIVERY_LOGGER.debug(
155-
"Message (id=%s, ack_id=%s, ordering_key=%s, exactly_once=%s) received by subscriber callback",
156-
message.message_id,
157-
message.ack_id,
158-
message.ordering_key,
159-
message.exactly_once_enabled,
160-
)
161-
162154
try:
163155
if message.opentelemetry_data:
164156
message.opentelemetry_data.end_subscribe_concurrency_control_span()
@@ -170,15 +162,9 @@ def _wrap_callback_errors(
170162
# Note: the likelihood of this failing is extremely low. This just adds
171163
# a message to a queue, so if this doesn't work the world is in an
172164
# unrecoverable state and this thread should just bail.
173-
174-
_CALLBACK_EXCEPTION_LOGGER.exception(
175-
"Message (id=%s, ack_id=%s, ordering_key=%s, exactly_once=%s)'s callback threw exception, nacking message.",
176-
message.message_id,
177-
message.ack_id,
178-
message.ordering_key,
179-
message.exactly_once_enabled,
165+
_LOGGER.exception(
166+
"Top-level exception occurred in callback while processing a message"
180167
)
181-
182168
message.nack()
183169
on_callback_error(exc)
184170

0 commit comments

Comments
 (0)