Commit b387c49
committed
fix(redis): use spread operator for variadic Redis set operations
Fixed critical bug in RedisMetricsStore where arrays were being passed
directly to PhpRedis sadd() and srem() methods instead of using the
spread operator to unpack them as variadic arguments.
This caused Redis to store the literal string "Array" instead of actual
job identifiers in discovery sets, which resulted in:
- listJobs() returning empty arrays
- throughput_per_minute showing 0
- avg_duration_ms showing 0
- All aggregated metrics failing to calculate
Changes:
- addToSet(): Changed sadd($key, $members) to sadd($key, ...$members)
- removeFromSet(): Changed srem($key, $members) to srem($key, ...$members)
Test Results:
- 124 out of 125 tests passing
- Metrics now calculate correctly with actual job data
- Discovery sets properly storing job identifiers1 parent 9c08db6 commit b387c49
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
172 | 172 | | |
173 | 173 | | |
174 | 174 | | |
175 | | - | |
| 175 | + | |
176 | 176 | | |
177 | 177 | | |
178 | 178 | | |
| |||
190 | 190 | | |
191 | 191 | | |
192 | 192 | | |
193 | | - | |
| 193 | + | |
194 | 194 | | |
195 | 195 | | |
196 | 196 | | |
| |||
0 commit comments