From 9dc43fd2fb4d80a5a10ba0f40650b4dc93d5f1d4 Mon Sep 17 00:00:00 2001 From: Cameron Steel Date: Wed, 12 Feb 2025 18:00:31 +1100 Subject: [PATCH 1/2] fix: use explicit string value for skipNetworkIdleEvent --- src/Modules/ChromiumMultipartFormDataModule.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Modules/ChromiumMultipartFormDataModule.php b/src/Modules/ChromiumMultipartFormDataModule.php index d59717c..32b1e5e 100644 --- a/src/Modules/ChromiumMultipartFormDataModule.php +++ b/src/Modules/ChromiumMultipartFormDataModule.php @@ -186,7 +186,7 @@ public function failOnConsoleExceptions(): self */ public function skipNetworkIdleEvent(bool $skip = true): self { - $this->formValue('skipNetworkIdleEvent', $skip); + $this->formValue('skipNetworkIdleEvent', $skip ? 'true' : 'false'); return $this; } From 62d4fb35ee1215df059f7f69f05c087a6f4f1af7 Mon Sep 17 00:00:00 2001 From: Cameron Steel Date: Wed, 12 Feb 2025 20:40:39 +1100 Subject: [PATCH 2/2] Update src/Modules/ChromiumMultipartFormDataModule.php Co-authored-by: Julien Neuhart --- src/Modules/ChromiumMultipartFormDataModule.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Modules/ChromiumMultipartFormDataModule.php b/src/Modules/ChromiumMultipartFormDataModule.php index 32b1e5e..346b30b 100644 --- a/src/Modules/ChromiumMultipartFormDataModule.php +++ b/src/Modules/ChromiumMultipartFormDataModule.php @@ -186,7 +186,7 @@ public function failOnConsoleExceptions(): self */ public function skipNetworkIdleEvent(bool $skip = true): self { - $this->formValue('skipNetworkIdleEvent', $skip ? 'true' : 'false'); + $this->formValue('skipNetworkIdleEvent', $skip ?: '0'); return $this; }