Skip to content
This repository was archived by the owner on Jul 19, 2023. It is now read-only.

Commit eed3d16

Browse files
committed
Use load on the atomic page stats
1 parent cd841cc commit eed3d16

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

pkg/phlaredb/query/iters.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -751,7 +751,7 @@ func (r *RowNumberIterator[T]) Seek(to RowNumberWithDefinitionLevel) bool {
751751
return true
752752
}
753753

754-
// SyncIterator is like ColumnIterator but synchronous. It scans through the given row
754+
// SyncIterator is a synchronous column iterator. It scans through the given row
755755
// groups and column, and applies the optional predicate to each chunk, page, and value.
756756
// Results are read by calling Next() until it returns nil.
757757
type SyncIterator struct {
@@ -1180,12 +1180,12 @@ func (c *SyncIterator) Err() error {
11801180
func (c *SyncIterator) Close() error {
11811181
c.closeCurrRowGroup()
11821182

1183-
c.span.SetTag("inspectedColumnChunks", c.filter.InspectedColumnChunks)
1184-
c.span.SetTag("inspectedPages", c.filter.InspectedPages)
1185-
c.span.SetTag("inspectedValues", c.filter.InspectedValues)
1186-
c.span.SetTag("keptColumnChunks", c.filter.KeptColumnChunks)
1187-
c.span.SetTag("keptPages", c.filter.KeptPages)
1188-
c.span.SetTag("keptValues", c.filter.KeptValues)
1183+
c.span.SetTag("inspectedColumnChunks", c.filter.InspectedColumnChunks.Load())
1184+
c.span.SetTag("inspectedPages", c.filter.InspectedPages.Load())
1185+
c.span.SetTag("inspectedValues", c.filter.InspectedValues.Load())
1186+
c.span.SetTag("keptColumnChunks", c.filter.KeptColumnChunks.Load())
1187+
c.span.SetTag("keptPages", c.filter.KeptPages.Load())
1188+
c.span.SetTag("keptValues", c.filter.KeptValues.Load())
11891189
c.span.Finish()
11901190
return nil
11911191
}

0 commit comments

Comments
 (0)