Skip to content

Commit 2ab985b

Browse files
jcs-instructorgregorrieglernitsanavni4dsherwoodmander11
committed
. t wip: test with different injected rule
Co-Authored-By: Gregor Riegler <rieglerg85@gmail.com> Co-Authored-By: Nitsan Avni <nitsanav@gmail.com> Co-Authored-By: Joel Silberman <42779942+jcs-instructor@users.noreply.github.com> Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com> Co-Authored-By: Matt <matthew.anderson11@gmail.com>
1 parent c3fdff5 commit 2ab985b

File tree

2 files changed

+28
-0
lines changed

2 files changed

+28
-0
lines changed

katas/fizzbuzz/test_fizzbuzz.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,18 @@ def test_buzz(fizzbuzz_db):
7272
fizzbuzz_fn = make_fizzbuzz(fizzbuzz_db)
7373
assert "Buzz" == fizzbuzz_fn(5)
7474

75+
def test_different_rules(fizzbuzz_db):
76+
rules = fizzbuzz_db.fizzbuzz_rules
77+
rules.insert_many(
78+
[
79+
{"word": "Fizz", "divisor": 3},
80+
{"word": "Buzz", "divisor": 5},
81+
# add Bang, 7
82+
]
83+
)
84+
fizzbuzz_fn = make_fizzbuzz(fizzbuzz_db)
85+
assert "Bang" == fizzbuzz_fn(7)
86+
7587
def skip_test_15(fizzbuzz_db):
7688
fizzbuzz_fn = make_fizzbuzz(fizzbuzz_db)
7789
assert "FizzBuzz" == fizzbuzz_fn(15)

session-notes/session-notes-2024-04-25.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,22 @@ Joel
7474

7575
### Mid-Session Retro 2 (1 minute per person - what liked/disliked & propose changes)
7676

77+
Nitsan
78+
- In retrospect, prefer not to be testing 7, but 5 again; only change 1 thing between 2 tests; last tested 5, so
79+
now do it again and expect a different word (only change was the rule, not the number); e.g., input = 5, word = something else
80+
81+
Diana
82+
- Like that we have a rotation with being Typer first and then becoming the Talker
83+
- Used my turn to get better understanding
84+
- Wait and watch
85+
86+
Joel
87+
- Getting into a bit of a flow
88+
- Figuring out how to write this test
89+
- a test for not fizz nor buzz: two variables: 1. the number 2. the rules
90+
- Next: continue as we are
91+
- Good to do the retro now
92+
7793
### Final Retro
7894

7995
### How we spent our time today:

0 commit comments

Comments
 (0)