. r wip: refactor to loop through rules rather than hard code applying them

Co-Authored-By: Gregor Riegler <rieglerg85@gmail.com>
Co-Authored-By: Nitsan Avni <nitsanav@gmail.com>
Co-Authored-By: Joel Silberman <42779942+jcs-instructor@users.noreply.github.com>
Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com>
Co-Authored-By: Matt <matthew.anderson11@gmail.com>

Author: 5 people

katas/fizzbuzz/test_fizzbuzz.py

@@ -53,8 +53,16 @@ def test_buzz_divisor_is_5(fizzbuzz_db):
 FizzbuzzFn = Callable[[int], str]
 
 # todo: move this production code to another file later:
+## grab all rules and sort them by divisor and loop through (rather than being hardcoded)
+#failing test to surface something
 def make_fizzbuzz(db) -> FizzbuzzFn:
     def fizzbuzz_fn(number):  
+        # get the rules from DB sorted by the divisor
+        rules = db.fizzbuzz_rules.find().sort("divisor", 1)
+        for rule in rules:
+            print(rule)
+        # loop through each rule and append the word if the input number is divisible by the divisor
+        #retrun the number as a string
         divisor = 5
         word = db.fizzbuzz_rules.find_one({"divisor": divisor})["word"]        
         if number == divisor:

session-notes/session-notes-2024-04-25.md

@@ -125,6 +125,23 @@ Nitsan
 - Liked how we uncovered the bug for the new test, i.e., duplicate test with new rule; resulted in different failure.
 - Is this a refactoring, or are we adding functionality? Duplication can be refactored. Mainly we are still adding functionality.
 
+### Retro 5
+
+Diana
+- was very important to write the comments and pseudo-code
+- just followed it
+- did not understand the intention w/o the comments; fine following
+- amazing - ChatGPT gave us something too verbose; still learned from it
+
+Joel
+- like our progress
+- found it easier to state intentions with comments / pseudo-code; capturing on the screen makes it easier to follow
+- enjoyed the session!
+
+Nitsan
+- Like doing fizzbuzz with db - so many considerations; very interesting to manage everyone's understanding 
+- Don't have a clear idea how to go about it, but like exploring different directions together
+
 ### Final Retro
 
 ### How we spent our time today: