. t Create fizzbuzz function with db injected

Co-Authored-By: Nitsan Avni <nitsanav@gmail.com>
Co-Authored-By: Joel Silberman <42779942+jcs-instructor@users.noreply.github.com>
Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com>
Co-Authored-By: Kevin Maes <kevin@kevinmaes.com>
Co-Authored-By: Matt <matthew.anderson11@gmail.com>

Author: 5 people

katas/fizzbuzz/test_fizzbuzz.py

@@ -1,10 +1,23 @@
 import mongomock
 import pytest
+from typing import Callable
 
 @pytest.fixture
 def mock_mongo_client():
     return mongomock.MongoClient()
 
+@pytest.fixture
+def fizzbuzz_db(mock_mongo_client):
+    db = mock_mongo_client.mydatabase
+    rules = db.fizzbuzz_rules
+    rules.insert_many(
+        [
+            {"word": "Fizz", "divisor": 3},
+            {"word": "Buzz", "divisor": 5},
+        ]
+    )
+    return db
+
 def test_example_using_mock_db(mock_mongo_client):
     db = mock_mongo_client.mydatabase
     collection = db.ourcollection
@@ -14,14 +27,34 @@ def test_example_using_mock_db(mock_mongo_client):
 
     assert result["age"] == 30
 
+
 def test_have_fizz_buzz_specs_in_DB(mock_mongo_client):
     db = mock_mongo_client.mydatabase
-    collection = db.ourcollection
+    rules = db.fizzbuzz_rules
+    rules.insert_many(
+        [
+            {"word": "Fizz", "divisor": 3},
+            {"word": "Buzz", "divisor": 5},
+        ]
+    )
+    result = rules.find_one({"word": "Fizz"})
+
+    assert result["divisor"] == 3
+
+def test_fizz_divisor_is_3(fizzbuzz_db):    
+    assert fizzbuzz_db.fizzbuzz_rules.find_one({"word": "Fizz"})["divisor"] == 3
+
+
+def test_buzz_divisor_is_5(fizzbuzz_db):
+    assert fizzbuzz_db.fizzbuzz_rules.find_one({"word": "Buzz"})["divisor"] == 5
+
+FizzbuzzFn = Callable[[int], str]
 
-    # input: 9
-    # output: fizz
-    # denominator: 3
-    collection.insert_one({"word": "Fizz", "denominator": 3})
-    result = collection.find_one({"word": "Fizz"})
+def make_fizzbuzz(db) -> FizzbuzzFn:
+    def fizzbuzz_fn(number):  
+        return "Fizz"
+    return fizzbuzz_fn
 
-    assert result["denominator"] == 3
+def test_fizzbuzz(fizzbuzz_db):
+    fizzbuzz_fn = make_fizzbuzz(fizzbuzz_db)
+    assert "Fizz" == fizzbuzz_fn(3)    

session-notes/session-notes-2024-04-18.md

@@ -101,6 +101,16 @@ Nitsan
 
 ### Final Retro
 
+Nitsan
+- Now see a clear path, how we can TDD multiple paths
+- Interesting: how does the mock mongo relate to using an actual mongo connection?
+- Could do end-to-end testing with a real database, not just mock
+
+Joel
+- Like how things are unfolding
+- Found it a bit confusing - injecting something to a function in python; putting the production code in the test code itself
+- A better name for `ret` (maybe `fizzbuzz_factory` -> returing a `fizzbuzz_function`)
+
 ### How we spent our time today:
 - Time-Archivist will record the total time for each section of today's session:
   - __ minutes coding