Skip to content

Commit e468dbf

Browse files
jcs-instructorgregorrieglernitsanavni4dsherwoodmander11
committed
. t inject a non-Buzz word for 3
Co-Authored-By: Gregor Riegler <rieglerg85@gmail.com> Co-Authored-By: Nitsan Avni <nitsanav@gmail.com> Co-Authored-By: Joel Silberman <42779942+jcs-instructor@users.noreply.github.com> Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com> Co-Authored-By: Matt <matthew.anderson11@gmail.com>
1 parent ac188d5 commit e468dbf

File tree

2 files changed

+30
-1
lines changed

2 files changed

+30
-1
lines changed

katas/fizzbuzz/test_fizzbuzz.py

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,20 @@ def test_buzz(fizzbuzz_db):
7373
fizzbuzz_fn = make_fizzbuzz(fizzbuzz_db)
7474
assert "Buzz" == fizzbuzz_fn(5)
7575

76-
def test_different_rules(fizzbuzz_db):
76+
# test: a non-fizzbuzz rule for 3
77+
78+
def test_wow_instead_of_fizz(fizzbuzz_db):
79+
rules = fizzbuzz_db.fizzbuzz_rules
80+
# rules.delete_many(filter={})
81+
rules.insert_many(
82+
[
83+
{"word": "Wow", "divisor": 3},
84+
]
85+
)
86+
fizzbuzz_fn = make_fizzbuzz(fizzbuzz_db)
87+
assert "Wow" == fizzbuzz_fn(3)
88+
89+
def test_Bang_instead_of_Buzz(fizzbuzz_db):
7790
rules = fizzbuzz_db.fizzbuzz_rules
7891
rules.delete_many(filter={})
7992
rules.insert_many(

session-notes/session-notes-2024-04-25.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,22 @@ Joel
109109
- Clear intentions: helps with different ideas people might have
110110

111111

112+
### Retro 4
113+
114+
Diana
115+
- I have faith we'll get there this way with the group
116+
- Having the db, and ask something wrong, that would fail
117+
118+
Joel
119+
- Like the pattern we have
120+
- Something we're doing is a bit confusing
121+
- Maybe extract helper function for readability
122+
- Losing track about red / refactor
123+
124+
Nitsan
125+
- Liked how we uncovered the bug for the new test, i.e., duplicate test with new rule; resulted in different failure.
126+
- Is this a refactoring, or are we adding functionality? Duplication can be refactored. Mainly we are still adding functionality.
127+
112128
### Final Retro
113129

114130
### How we spent our time today:

0 commit comments

Comments
 (0)