From 4003d553494eaa79d08f5d21506d856f927ae6e4 Mon Sep 17 00:00:00 2001 From: "ugo.bechameil" Date: Mon, 30 Jun 2025 20:10:49 +0200 Subject: [PATCH] As the modal is not dynamic at all we are force to rollback to a more usable state --- .../connectionSettingsModalConfig.json | 16 +--------------- reverse_engineering/helpers/connectionHelper.js | 2 +- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/reverse_engineering/connection_settings_modal/connectionSettingsModalConfig.json b/reverse_engineering/connection_settings_modal/connectionSettingsModalConfig.json index 91415bd..a30c7cc 100644 --- a/reverse_engineering/connection_settings_modal/connectionSettingsModalConfig.json +++ b/reverse_engineering/connection_settings_modal/connectionSettingsModalConfig.json @@ -19,21 +19,7 @@ "inputKeyword": "projectId", "inputType": "text", "inputTooltip": "Project ID on Google Cloud Platform", - "dependency": { - "key": "authType", - "value": "app_default_credentials" - } - }, - { - "inputLabel": "Project ID", - "inputKeyword": "optionalProjectId", - "inputType": "text", - "inputPlaceholder": "Optional", - "inputTooltip": "Project ID on Google Cloud Platform", - "dependency": { - "key": "authType", - "value": "service_account_key" - } + "inputPlaceholder": "Optional if using service account" }, { "inputLabel": "Dataset name", diff --git a/reverse_engineering/helpers/connectionHelper.js b/reverse_engineering/helpers/connectionHelper.js index 6a08440..2aa9bf2 100644 --- a/reverse_engineering/helpers/connectionHelper.js +++ b/reverse_engineering/helpers/connectionHelper.js @@ -14,7 +14,7 @@ function getAuthInfo({ authType, connectionInfo }) { } // service account case and backward compatible value return { - projectId: connectionInfo?.optionalProjectId, + projectId: connectionInfo.projectId, credentialsFilePath: connectionInfo.keyFilename, }; }