Satisfy clang-tidy

Author: mcourteaux

src/LegalizeVectors.cpp

@@ -131,6 +131,7 @@ class ExtractLanes : public IRMutator {
 
     Expr visit(const Shuffle *op) override {
         vector<int> new_indices;
+        new_indices.reserve(lane_count);
         for (int i = 0; i < lane_count; ++i) {
             new_indices.push_back(op->indices[lane_start + i]);
         }
@@ -428,8 +429,8 @@ class LegalizeVectors : public IRMutator {
     Expr visit(const Shuffle *op) override {
         internal_assert(op->type.lanes() <= max_lanes) << Expr(op);
         bool requires_mutation = false;
-        for (size_t i = 0; i < op->vectors.size(); ++i) {
-            if (op->vectors[i].type().lanes() > max_lanes) {
+        for (const auto &vec : op->vectors) {
+            if (vec.type().lanes() > max_lanes) {
                 requires_mutation = true;
                 break;
             }

src/Simplify_Shuffle.cpp

@@ -67,8 +67,8 @@ Expr Simplify::visit(const Shuffle *op, ExprInfo *info) {
             arg_used[src_vec_and_lane_idx[i].first] = true;
         }
         size_t num_args_used = 0;
-        for (size_t i = 0; i < arg_used.size(); ++i) {
-            if (arg_used[i]) {
+        for (bool used : arg_used) {
+            if (used) {
                 num_args_used++;
             }
         }
@@ -83,10 +83,10 @@ Expr Simplify::visit(const Shuffle *op, ExprInfo *info) {
                     for (int i = 0; i < vi; ++i) {
                         vector_start_lane += op->vectors[i].type().lanes();
                     }
-                    for (size_t i = 0; i < new_indices.size(); ++i) {
-                        if (new_indices[i] > vector_start_lane) {
-                            internal_assert(new_indices[i] >= vector_start_lane + lanes_deleted);
-                            new_indices[i] -= lanes_deleted;
+                    for (int &new_index : new_indices) {
+                        if (new_index > vector_start_lane) {
+                            internal_assert(new_index >= vector_start_lane + lanes_deleted);
+                            new_index -= lanes_deleted;
                         }
                     }
                     new_vectors.erase(new_vectors.begin() + vi);