Fix Makefile and symbol visibility issue.

Author: mcourteaux

Makefile

@@ -684,6 +684,7 @@ HEADER_FILES = \
   ExternFuncArgument.h \
   ExtractTileOperations.h \
   FastIntegerDivide.h \
+  FastMathFunctions.h \
   FindCalls.h \
   FindIntrinsics.h \
   FlattenNestedRamps.h \

src/ApproximationTables.cpp

@@ -1019,6 +1019,30 @@ const Approximation *best_log_approximation(Halide::ApproximationPrecision preci
     return find_best_approximation("log", table_log, precision, type);
 }
 
+// ====
+
+const std::vector<Approximation> &get_table_atan() {
+  return table_atan;
+}
+const std::vector<Approximation> &get_table_sin() {
+  return table_sin;
+}
+const std::vector<Approximation> &get_table_cos() {
+  return table_cos;
+}
+const std::vector<Approximation> &get_table_tan() {
+  return table_tan;
+}
+const std::vector<Approximation> &get_table_expm1() {
+  return table_expm1;
+}
+const std::vector<Approximation> &get_table_exp() {
+  return table_exp;
+}
+const std::vector<Approximation> &get_table_log() {
+  return table_log;
+}
+
 }  // namespace ApproximationTables
 }  // namespace Internal
 }  // namespace Halide

src/ApproximationTables.h

@@ -32,13 +32,13 @@ struct Approximation {
 };
 
 namespace ApproximationTables {
-extern HALIDE_EXPORT_SYMBOL const std::vector<Approximation> table_atan;
-extern HALIDE_EXPORT_SYMBOL const std::vector<Approximation> table_sin;
-extern HALIDE_EXPORT_SYMBOL const std::vector<Approximation> table_cos;
-extern HALIDE_EXPORT_SYMBOL const std::vector<Approximation> table_tan;
-extern HALIDE_EXPORT_SYMBOL const std::vector<Approximation> table_expm1;
-extern HALIDE_EXPORT_SYMBOL const std::vector<Approximation> table_exp;
-extern HALIDE_EXPORT_SYMBOL const std::vector<Approximation> table_log;
+const std::vector<Approximation> &get_table_atan();
+const std::vector<Approximation> &get_table_sin();
+const std::vector<Approximation> &get_table_cos();
+const std::vector<Approximation> &get_table_tan();
+const std::vector<Approximation> &get_table_expm1();
+const std::vector<Approximation> &get_table_exp();
+const std::vector<Approximation> &get_table_log();
 
 const Approximation *best_atan_approximation(Halide::ApproximationPrecision precision, Type type);
 const Approximation *best_sin_approximation(Halide::ApproximationPrecision precision, Type type);

test/correctness/determine_fast_function_approximation_metrics.cpp

@@ -91,55 +91,55 @@ struct FunctionToTest {
         [](Expr x, Expr y) { return Halide::tan(x); },
         [](Expr x, Expr y, Halide::ApproximationPrecision prec) { return Halide::fast_tan(x, prec); },
         Halide::Internal::ApproximationTables::best_tan_approximation,
-        Halide::Internal::ApproximationTables::table_tan,
+        Halide::Internal::ApproximationTables::get_table_tan(),
         {0.0f, float(PI_OVER_FOUR)},
     },
     {
         "atan", OO::MULPE,
         [](Expr x, Expr y) { return Halide::atan(x); },
         [](Expr x, Expr y, Halide::ApproximationPrecision prec) { return Halide::fast_atan(x, prec); },
         Halide::Internal::ApproximationTables::best_atan_approximation,
-        Halide::Internal::ApproximationTables::table_atan,
+        Halide::Internal::ApproximationTables::get_table_atan(),
         {0.0f, 32.0f},
     },
     {
         "sin", OO::MULPE,
         [](Expr x, Expr y) { return Halide::sin(x); },
         [](Expr x, Expr y, Halide::ApproximationPrecision prec) { return Halide::fast_sin(x, prec); },
         Halide::Internal::ApproximationTables::best_sin_approximation,
-        Halide::Internal::ApproximationTables::table_sin,
+        Halide::Internal::ApproximationTables::get_table_sin(),
         {0.0f, float(PI_OVER_TWO)},
     },
     {
         "cos", OO::MAE, // Only MAE uses the cos table. MULPE gets redirected to fast_sin.
         [](Expr x, Expr y) { return Halide::cos(x); },
         [](Expr x, Expr y, Halide::ApproximationPrecision prec) { return Halide::fast_cos(x, prec); },
         Halide::Internal::ApproximationTables::best_cos_approximation,
-        Halide::Internal::ApproximationTables::table_cos,
+        Halide::Internal::ApproximationTables::get_table_cos(),
         {0.0f, float(PI_OVER_TWO)},
     },
     {
         "expm1", OO::MULPE,
         [](Expr x, Expr y) { return makeshift_expm1(x); },
         [](Expr x, Expr y, Halide::ApproximationPrecision prec) { return Halide::fast_expm1(x, prec); },
         Halide::Internal::ApproximationTables::best_expm1_approximation,
-        Halide::Internal::ApproximationTables::table_expm1,
+        Halide::Internal::ApproximationTables::get_table_expm1(),
         {-float(0.5 * std::log(2.0)), float(0.5 * std::log(2.0))},
     },
     {
         "exp", OO::MULPE,
         [](Expr x, Expr y) { return Halide::exp(x); },
         [](Expr x, Expr y, Halide::ApproximationPrecision prec) { return Halide::fast_exp(x, prec); },
         Halide::Internal::ApproximationTables::best_exp_approximation,
-        Halide::Internal::ApproximationTables::table_exp,
+        Halide::Internal::ApproximationTables::get_table_exp(),
         {0.0f, float(std::log(2.0))},
     },
     {
         "log", OO::MULPE,
         [](Expr x, Expr y) { return Halide::log(x); },
         [](Expr x, Expr y, Halide::ApproximationPrecision prec) { return Halide::fast_log(x, prec); },
         Halide::Internal::ApproximationTables::best_log_approximation,
-        Halide::Internal::ApproximationTables::table_log,
+        Halide::Internal::ApproximationTables::get_table_log(),
         {0.75f, 1.50f},
     },
     // clang-format on